From: Mike Frysinger <vapier@gentoo.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: add ppoll syscall support
Date: Sun, 23 Jan 2011 16:35:39 -0500 [thread overview]
Message-ID: <AANLkTikHyGY6D72hsjds_DWg-HMw-1DmnGt-r-Q9oSxD@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikf6Vs7pQf9iuL_6QvhxhZHwCa1o_udUj=rA4X9@mail.gmail.com>
On Sun, Jan 23, 2011 at 16:25, Peter Maydell wrote:
> On 23 January 2011 19:56, Mike Frysinger wrote:
>> Some architectures (like Blackfin) only implement ppoll (and skip poll).
>> So add support for it using existing poll code.
>
> This looks wrong -- ppoll() is supposed to be atomic, but
> your implementation isn't. Why can't we just implement this
> by calling the host ppoll? (might need a configure test, but
> that's straightforward.)
it's atomic from the apps' point of view, so what does it matter ?
-mike
next prev parent reply other threads:[~2011-01-23 21:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 19:56 [Qemu-devel] [PATCH] linux-user: add ppoll syscall support Mike Frysinger
2011-01-23 21:25 ` Peter Maydell
2011-01-23 21:35 ` Mike Frysinger [this message]
2011-01-23 22:35 ` Peter Maydell
2011-01-23 22:54 ` Mike Frysinger
2011-01-23 23:32 ` [Qemu-devel] [PATCH v2] " Mike Frysinger
2011-01-24 0:35 ` Peter Maydell
2011-01-24 3:57 ` [Qemu-devel] [PATCH v3] " Mike Frysinger
2011-01-24 11:55 ` Peter Maydell
2011-01-25 9:44 ` [Qemu-devel] [PATCH v4] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikHyGY6D72hsjds_DWg-HMw-1DmnGt-r-Q9oSxD@mail.gmail.com \
--to=vapier@gentoo.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).