Re: [Qemu-devel] [PATCH v4 00/10] initial spice support.

[Blue Swirl <blauwirbel@gmail.com>]

On Mon, Aug 30, 2010 at 8:48 AM, Gerd Hoffmann <kraxel@redhat.com> wrote:
> On 08/28/10 08:42, Blue Swirl wrote:
>>
>> On Fri, Aug 27, 2010 at 9:59 AM, Gerd Hoffmann<kraxel@redhat.com>  wrote:
>>>
>>>  Hi,
>>>
>>> Here comes v4 of the iniial spice support patch series, hopefully the
>>> final version.  It brings just the very basic bits:
>>>
>>>  * Detect spice in configure, Makefile windup.
>>>  * Support for keyboard, mouse and tablet.
>>>  * Support for simple display output (works as DisplayChangeListener,
>>>   plays with any gfx card, sends simple draw commands to update
>>>   dirty regions).
>>>
>>> Note that this patch series does *not* yet contain the qxl paravirtual
>>> gfx card.  That will come as part of a additional patch series after
>>> sorting the vgabios support.
>>>
>>> The patches are also available in the git repository at:
>>>  git://anongit.freedesktop.org/spice/qemu submit.4
>>
>> Please read CODING_STYLE, especially the braces rule.
>
> I'm aware of the coding style.

Wilful misconduct? May I ask if there are other things that you don't
agree with and you are covertly working against?

>  I'm also aware of the recent
> flam^Wdiscussions on that topic, especially the braces rule.  I didn't read
> the whole thread though.  Is there some result?  If so, can someone
> summarize please?

There was no conclusion. One point that was raised is that
reformatting of existing code was seen problematic. That would mean
that if offending code is let in, it will never be fixed.