From: Blue Swirl <blauwirbel@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 04/10] ne2000_isa: make optional
Date: Sun, 13 Feb 2011 00:41:31 +0200 [thread overview]
Message-ID: <AANLkTikL4P4AtZVXC-L578K06La-KVqRfnqq5pVyfcQy@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
Ignore failure with ne2000_isa device creation.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
hw/pc.h | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/pc.h b/hw/pc.h
index abdf307..50d9943 100644
--- a/hw/pc.h
+++ b/hw/pc.h
@@ -5,6 +5,7 @@
#include "ioport.h"
#include "isa.h"
#include "fdc.h"
+#include "net.h"
/* PC-style peripherals (also used by other machines). */
@@ -176,17 +177,21 @@ void pci_cirrus_vga_init(PCIBus *bus);
void isa_cirrus_vga_init(void);
/* ne2000.c */
-static inline void isa_ne2000_init(int base, int irq, NICInfo *nd)
+static inline bool isa_ne2000_init(int base, int irq, NICInfo *nd)
{
ISADevice *dev;
qemu_check_nic_model(nd, "ne2k_isa");
- dev = isa_create("ne2k_isa");
+ dev = isa_try_create("ne2k_isa");
+ if (!dev) {
+ return false;
+ }
qdev_prop_set_uint32(&dev->qdev, "iobase", base);
qdev_prop_set_uint32(&dev->qdev, "irq", irq);
qdev_set_nic_properties(&dev->qdev, nd);
qdev_init_nofail(&dev->qdev);
+ return true;
}
/* e820 types */
--
1.6.2.4
[-- Attachment #2: 0004-ne2000_isa-make-optional.patch --]
[-- Type: application/mbox, Size: 1579 bytes --]
reply other threads:[~2011-02-12 22:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikL4P4AtZVXC-L578K06La-KVqRfnqq5pVyfcQy@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).