From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49793 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q4DuV-0003iF-WA for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:59:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q4DuU-0003dq-B7 for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:59:15 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:62104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q4DuU-0003dM-7v for qemu-devel@nongnu.org; Mon, 28 Mar 2011 10:59:14 -0400 Received: by vws17 with SMTP id 17so2658451vws.4 for ; Mon, 28 Mar 2011 07:59:12 -0700 (PDT) MIME-Version: 1.0 Sender: anthony.perard@gmail.com In-Reply-To: <315066AB-DAF8-4665-A987-CBB0DD553F47@suse.de> References: <1299004529-31290-1-git-send-email-anthony.perard@citrix.com> <1299004529-31290-3-git-send-email-anthony.perard@citrix.com> <315066AB-DAF8-4665-A987-CBB0DD553F47@suse.de> From: Anthony PERARD Date: Mon, 28 Mar 2011 15:50:13 +0100 Message-ID: Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH V11 02/15] xen: Make Xen build once. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Xen Devel , QEMU-devel , Stefano Stabellini On Wed, Mar 23, 2011 at 10:57, Alexander Graf wrote: > > On 01.03.2011, at 19:35, Anthony.Perard@citrix.com wrote: > >> From: Anthony PERARD >> >> xen_domainbuild is now build in libhw. And xen_machine_pv is build only >> for i386 targets. >> >> Signed-off-by: Anthony PERARD >> --- >> Makefile.objs =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A03 +++ >> Makefile.target =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A02 +- >> hw/xen_domainbuild.c | =C2=A0 10 +++++----- >> hw/xen_domainbuild.h | =C2=A0 =C2=A05 +++-- >> hw/xen_machine_pv.c =C2=A0| =C2=A0 =C2=A02 +- >> 5 files changed, 13 insertions(+), 9 deletions(-) >> >> diff --git a/Makefile.objs b/Makefile.objs >> index 9e98a66..8034115 100644 >> --- a/Makefile.objs >> +++ b/Makefile.objs >> @@ -269,6 +269,9 @@ hw-obj-$(CONFIG_DP8393X) +=3D dp8393x.o >> hw-obj-$(CONFIG_DS1225Y) +=3D ds1225y.o >> hw-obj-$(CONFIG_MIPSNET) +=3D mipsnet.o >> >> +# Xen >> +hw-obj-$(CONFIG_XEN) +=3D xen_domainbuild.o > > Why is this in generic code? Xen is x86 only and really should stay that = way IMHO. I just try to build more object globally to avoid unnecessary i386-isms. >> + >> # Sound >> sound-obj-y =3D >> sound-obj-$(CONFIG_SB16) +=3D sb16.o >> diff --git a/Makefile.target b/Makefile.target >> index 220589e..ab0a570 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -206,7 +206,7 @@ QEMU_CFLAGS +=3D $(VNC_JPEG_CFLAGS) >> QEMU_CFLAGS +=3D $(VNC_PNG_CFLAGS) >> >> # xen backend driver support >> -obj-$(CONFIG_XEN) +=3D xen_machine_pv.o xen_domainbuild.o >> +obj-i386-$(CONFIG_XEN) +=3D xen_machine_pv.o >> >> # Inter-VM PCI shared memory >> obj-$(CONFIG_KVM) +=3D ivshmem.o >> diff --git a/hw/xen_domainbuild.c b/hw/xen_domainbuild.c >> index 7f1fd66..b73d47f 100644 >> --- a/hw/xen_domainbuild.c >> +++ b/hw/xen_domainbuild.c >> @@ -1,9 +1,9 @@ >> #include >> -#include "xen_backend.h" >> -#include "xen_domainbuild.h" >> #include "sysemu.h" >> #include "qemu-timer.h" >> #include "qemu-log.h" >> +#include "xen_backend.h" >> +#include "xen_domainbuild.h" >> >> #include >> >> @@ -49,7 +49,7 @@ static int xenstore_domain_mkdir(char *path) >> } >> >> int xenstore_domain_init1(const char *kernel, const char *ramdisk, >> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0const char *cmdline) >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0const char *cmdline, ram_addr_t ram_size) > > Isn't ram_size a global anyways? What's the rationale behind moving it to= a parameter? Not saying I'm against it, just missed the reasoning here :) I put ram_size in a parameter because I don't found a way to access to is global variable, and also because in these function, ram_size is read only. So, I can just remove this patch and just put both xen_machine_pv xen_domainbuild in obj-i386-y. Regards, --=20 Anthony PERARD