From: Blue Swirl <blauwirbel@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/7] apic: Don't use SoftFloat uint32 type
Date: Sun, 19 Dec 2010 11:20:55 +0000 [thread overview]
Message-ID: <AANLkTikLCgHj3cFrL2sBWeP57LiwDi6wCJjMj_F2ngLR@mail.gmail.com> (raw)
In-Reply-To: <1292689531-18763-1-git-send-email-andreas.faerber@web.de>
On Sat, Dec 18, 2010 at 4:25 PM, Andreas Färber <andreas.faerber@web.de> wrote:
> softfloat.h's uint32 type has least-width semantics,
> whereas surrounding code uses uint32_t, so use uint32_t too.
I think patches 1 to 3 don't have much to do with softfloat, the type
uses are just general sloppiness to use non-standard types instead of
deliberate softfloat type use. So if there is a respin for some
reason, please split off those from the softfloat patches and adjust
the descriptions. Otherwise, if the patches are going to be applied,
splitting is not necessary.
prev parent reply other threads:[~2010-12-19 11:21 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 17:31 [Qemu-devel] [PATCH] softfloat: Fix function signature mismatches by using POSIX integer types Andreas Färber
2010-12-17 22:39 ` [Qemu-devel] [PATCH v2] " Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 1/7] apic: Don't use SoftFloat uint32 type Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 2/7] wdt_ib700: Don't use SoftFloat int64 type Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 3/7] target-i386: Don't use SoftFloat uint64 type Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 4/7] softfloat: Resolve type mismatches between declaration and implementation Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 5/7] softfloat: Drop [s]bits{8, 16, 32, 64} types in favor of [u]int{8, 16, 32, 64}_t Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 6/7] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t Andreas Färber
2010-12-18 16:25 ` [Qemu-devel] [PATCH v3 7/7] softfloat: Make float{32, 64}_to_uint16_round_to_zero() use uint_fast16_t Andreas Färber
2011-01-01 13:47 ` Andreas Färber
2011-01-04 19:39 ` [Qemu-devel] [PATCH, RFC v4 1/5] softfloat: Prepend QEMU-style header with derivation notice Andreas Färber
2011-01-04 19:39 ` [Qemu-devel] [PATCH v4 2/5] softfloat: Resolve type mismatches between declaration and implementation Andreas Färber
2011-01-04 19:39 ` [Qemu-devel] [PATCH v4 3/5] softfloat: Drop [s]bits{8, 16, 32, 64} types in favor of [u]int{8, 16, 32, 64}_t Andreas Färber
2011-01-04 19:39 ` [Qemu-devel] [PATCH v4 4/5] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t Andreas Färber
2011-01-04 19:39 ` [Qemu-devel] [FYI v4 5/5] softfloat: Make float{32, 64}_to_uint16_round_to_zero() use uint_fast16_t Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 01/10] [RESEND] softfloat: Prepend QEMU-style header with derivation notice Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 02/10] softfloat: Resolve type mismatches between declaration and implementation Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 03/10] softfloat: Drop [s]bits{8, 16, 32, 64} types in favor of [u]int{8, 16, 32, 64}_t Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 04/10] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 05/10] softfloat: Use [u]int_fast16_t consistently Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 06/10] softfloat: Drop [u]int8 types in favor of int_fast8_t Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 07/10] softfloat: Drop [u]int32 types in favor of [u]int_fast32_t Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 08/10] softfloat: Use [u]int_fast32_t consistently Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 09/10] softfloat: Drop [u]int64 types in favor of [u]int_fast64_t Andreas Färber
2011-03-07 0:34 ` [Qemu-devel] [PATCH v5 10/10] softfloat: Use [u]int_fast64_t consistently Andreas Färber
2011-03-07 9:56 ` Aurelien Jarno
2011-03-07 23:10 ` Andreas Färber
2011-03-08 6:04 ` Aurelien Jarno
2011-03-07 9:56 ` [Qemu-devel] [PATCH v5 07/10] softfloat: Drop [u]int32 types in favor of [u]int_fast32_t Aurelien Jarno
2011-03-07 23:16 ` Andreas Färber
2011-03-07 23:33 ` Aurelien Jarno
2011-03-07 9:56 ` [Qemu-devel] [PATCH v5 04/10] softfloat: Drop [u]int16 types in favor of [u]int_fast16_t Aurelien Jarno
2011-03-07 23:02 ` Andreas Färber
2011-03-07 23:28 ` Aurelien Jarno
2011-03-07 23:14 ` Peter Maydell
2011-03-07 23:37 ` Aurelien Jarno
2011-03-08 8:29 ` Peter Maydell
2011-03-08 8:49 ` Aurelien Jarno
2011-03-08 18:54 ` Andreas Färber
2011-03-21 21:11 ` Aurelien Jarno
2011-03-07 9:56 ` [Qemu-devel] [PATCH v5 03/10] softfloat: Drop [s]bits{8, 16, 32, 64} types in favor of [u]int{8, 16, 32, 64}_t Aurelien Jarno
2011-03-07 9:56 ` [Qemu-devel] [PATCH v5 02/10] softfloat: Resolve type mismatches between declaration and implementation Aurelien Jarno
2011-03-07 9:56 ` [Qemu-devel] [PATCH v5 01/10] [RESEND] softfloat: Prepend QEMU-style header with derivation notice Aurelien Jarno
2010-12-19 11:28 ` [Qemu-devel] [PATCH v3 4/7] softfloat: Resolve type mismatches between declaration and implementation Blue Swirl
2010-12-19 12:06 ` Andreas Färber
2010-12-18 20:19 ` [Qemu-devel] Re: [PATCH v3 3/7] target-i386: Don't use SoftFloat uint64 type Juan Quintela
2010-12-20 0:52 ` Huang Ying
2010-12-18 16:47 ` [Qemu-devel] Re: [PATCH v3 2/7] wdt_ib700: Don't use SoftFloat int64 type Richard W.M. Jones
2010-12-19 12:51 ` Andreas Färber
2010-12-19 14:16 ` Richard W.M. Jones
2010-12-19 14:28 ` Andreas Färber
2010-12-19 14:38 ` Blue Swirl
2010-12-19 15:07 ` Andreas Färber
2010-12-19 15:17 ` Blue Swirl
2010-12-19 11:20 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikLCgHj3cFrL2sBWeP57LiwDi6wCJjMj_F2ngLR@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).