From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54525 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pdqie-0005x1-2V for qemu-devel@nongnu.org; Fri, 14 Jan 2011 15:58:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdqiX-0005Jx-5A for qemu-devel@nongnu.org; Fri, 14 Jan 2011 15:57:55 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:34139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdqiX-0005Jg-0Y for qemu-devel@nongnu.org; Fri, 14 Jan 2011 15:57:53 -0500 Received: by pwj6 with SMTP id 6so711698pwj.4 for ; Fri, 14 Jan 2011 12:57:51 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4D30B650.9020703@cisco.com> References: <1295032341-6926-1-git-send-email-daahern@cisco.com> <1295032341-6926-3-git-send-email-daahern@cisco.com> <4D30B10A.20302@cisco.com> <4D30B650.9020703@cisco.com> From: Blue Swirl Date: Fri, 14 Jan 2011 20:57:31 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 02/11] config: settings from default-configs need to be included in header files Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Ahern Cc: qemu-devel@nongnu.org On Fri, Jan 14, 2011 at 8:47 PM, David Ahern wrote: > > > On 01/14/11 13:31, Blue Swirl wrote: >> On Fri, Jan 14, 2011 at 8:24 PM, David Ahern wrote: >>> >>> >>> On 01/14/11 13:17, Blue Swirl wrote: >>>> On Fri, Jan 14, 2011 at 7:12 PM, David Ahern wrote: >>>>> Currently, device config settings in the default-configs file are not propogated into the config*.h files. While the Makefile rules observe them through the *.mak files, the CONFIG options are not usable within the .c files. >>>>> >>>>> This patch adds the settings to the header files. To do that the host devices make file is renamed to config-host-devices.mak and the target devices mak file to config-target-devices.mak. >>>> >>>> NACK, see this thread for the previous discussion: >>>> http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg02268.html >>> >>> hmm.... so there is no interest in making the existing design actually >>> work? It's reinvent the config design or nothing? >>> >>> I'm looking to compile out all device models not relevant to my use case. >> >> That's OK, but the correct fix is to change the design of the machine >> model to something more advanced where the unwanted objects are simply >> not linked in, without any changes to board code. This is not so >> trivial and also many devices are not architecturally clean yet. > > A lot of changes are need to obtain that goal, and I am not the right > person to do them. Until that ideal design can be developed and > implemented why not take a small patch that fixes the existing design? > It's not a major change -- a very small one actually (4 files, 13 lines > modified). So far the approach has been to make changes only in line with that goal.