From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40813 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PizGW-0004kd-6x
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 20:06:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geleman@gmail.com>) id 1PizGV-0003cX-JA
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 20:06:12 -0500
Received: from mail-vw0-f45.google.com ([209.85.212.45]:49812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geleman@gmail.com>) id 1PizGV-0003cR-BA
	for qemu-devel@nongnu.org; Fri, 28 Jan 2011 20:06:11 -0500
Received: by vws12 with SMTP id 12so1328618vws.4
	for <qemu-devel@nongnu.org>; Fri, 28 Jan 2011 17:06:10 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1296227054-13194-1-git-send-email-kwolf@redhat.com>
References: <1296227054-13194-1-git-send-email-kwolf@redhat.com>
Date: Sat, 29 Jan 2011 09:06:10 +0800
Message-ID: <AANLkTikNGWVyv6PD4JDB93k8eQsEcvLXV8un9uBi2LEg@mail.gmail.com>
From: TeLeMan <geleman@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] raw-win32: Fix bdrv_flush return value
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

Thanks, It works very well on win7 and winxp.
--
SUN OF A BEACH



On Fri, Jan 28, 2011 at 23:04, Kevin Wolf <kwolf@redhat.com> wrote:
> Reported-by: TeLeMan <geleman@gmail.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>
> Hi TeLeMan,
>
> this seems to be the bug that was exposed by the recent qcow2 cache chang=
es.
> Can you give it a try on a real Windows setup? I have tested it only on W=
ine so
> far.
>
> Kevin
>
>
> =C2=A0block/raw-win32.c | =C2=A0 =C2=A02 +-
> =C2=A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/raw-win32.c b/block/raw-win32.c
> index 06c9710..c204a80 100644
> --- a/block/raw-win32.c
> +++ b/block/raw-win32.c
> @@ -153,7 +153,7 @@ static int raw_flush(BlockDriverState *bs)
> =C2=A0 =C2=A0 int ret;
>
> =C2=A0 =C2=A0 ret =3D FlushFileBuffers(s->hfile);
> - =C2=A0 =C2=A0if (ret !=3D 0) {
> + =C2=A0 =C2=A0if (ret =3D=3D 0) {
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 return -EIO;
> =C2=A0 =C2=A0 }
>
> --
> 1.7.2.3
>
>