From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42990 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PQK76-0001zn-Jw
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 08:31:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PQK75-00079Y-7z
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 08:31:20 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:54962)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PQK75-00079M-1A
	for qemu-devel@nongnu.org; Wed, 08 Dec 2010 08:31:19 -0500
Received: by wwi18 with SMTP id 18so1086028wwi.10
	for <qemu-devel@nongnu.org>; Wed, 08 Dec 2010 05:31:18 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1291810400-11309-2-git-send-email-agraf@suse.de>
References: <1291810400-11309-1-git-send-email-agraf@suse.de>
	<1291810400-11309-2-git-send-email-agraf@suse.de>
Date: Wed, 8 Dec 2010 13:31:17 +0000
Message-ID: <AANLkTikOCpsq1fOYtm6u-aX0+Tj9d3GzuRuGCm43oe2G@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 01/13] ide: split ide command
	interpretation off
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Joerg Roedel <Joerg.Roedel@amd.com>, Paul Brook <paul@codesourcery.com>, QEMU-devel Developers <qemu-devel@nongnu.org>, Blue Swirl <blauwirbel@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, tj@kernel.org, Roland Elek <elek.roland@gmail.com>, Sebastian Herbszt <herbszt@gmx.de>

On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf <agraf@suse.de> wrote:
> The ATA command interpretation code can be used for PATA and SATA
> interfaces alike. So let's split it out into a separate function.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
>
> ---
>
> v6 -> v7:
>
> =A0- use bus instead of opaque (stefanha)
> ---
> =A0hw/ide/core.c =A0 =A0 | =A0 20 ++++++++++++++------
> =A0hw/ide/internal.h | =A0 =A02 ++
> =A02 files changed, 16 insertions(+), 6 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>