From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36741 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtNLH-0002Tu-26 for qemu-devel@nongnu.org; Sat, 26 Feb 2011 11:50:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PtNLE-00062V-2W for qemu-devel@nongnu.org; Sat, 26 Feb 2011 11:50:02 -0500 Received: from mail-vx0-f173.google.com ([209.85.220.173]:43958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PtNLE-00062L-0E for qemu-devel@nongnu.org; Sat, 26 Feb 2011 11:50:00 -0500 Received: by vxb41 with SMTP id 41so2383692vxb.4 for ; Sat, 26 Feb 2011 08:49:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1298734819-1960-1-git-send-email-pbonzini@redhat.com> References: <1298734819-1960-1-git-send-email-pbonzini@redhat.com> From: Blue Swirl Date: Sat, 26 Feb 2011 18:49:38 +0200 Message-ID: Subject: Re: [Qemu-devel] [PATCH v2 uq/master 00/22] Win32 iothread support Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, aurelien@aurel32.net On Sat, Feb 26, 2011 at 5:39 PM, Paolo Bonzini wrote: > After gathering the comments about the two series I sent separately, > here is the full series for Win32 iothread support, ready to be > applied to uq/master. > > Patches 1 to 5 are generic Win32 improvements, including the qemu-thread > implementation. =C2=A0Because of complex dependencies, I think it's bette= r > if this part is also routed through uq/master. > > Patches 6 to 8 are generic threading improvements, including using > PTHREAD_MUTEX_ERRORCHECK as suggested by Jan. > > Patches 9 to 17 eliminate polling, replacing condition variable > timedwait with wait. > > Patch 18 removes a redundant condition from the TCG cpu_exec_all > function. > > Patches 19 to 21 add all necessary stubs to make iothread compile > with Win32, except the IPI calls. =C2=A0These are provided by patch 22. > > Tested on Wine and Linux, not on "real" Windows. =C2=A0The series introdu= ces > a dependency on Windows 2K or newer. =C2=A0I don't think either 95/98/ME > or Windows NT 3.x are reasonable host systems for QEMU, anyway. > > I incorporated all suggestions from Jan, including his renaming patch > for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted. All look OK except for a minor structure naming nitpick.