From: Blue Swirl <blauwirbel@gmail.com>
To: malc <av1474@comtv.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable
Date: Thu, 7 Oct 2010 17:36:36 +0000 [thread overview]
Message-ID: <AANLkTikTXnq7N+--tmgZwnimmw31Nv2g97T5KqVWMOQ8@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1010071225170.1817@linmac>
On Thu, Oct 7, 2010 at 8:27 AM, malc <av1474@comtv.ru> wrote:
> On Thu, 7 Oct 2010, Paolo Bonzini wrote:
>
>> On 10/06/2010 11:34 PM, Blue Swirl wrote:
>> > Compiling with GCC 4.6.0 20100925 produced warnings:
>> > /src/qemu/target-i386/op_helper.c: In function 'switch_tss':
>> > /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap'
>> > set but not used [-Werror=unused-but-set-variable]
>> >
>> > Fix by deleting the variable.
>>
>> Again, this warning tells us the emulation is incorrect, so it's wrong to
>> remove it.
>>
>
> http://support.amd.com/us/Processor_TechDocs/24593.pdf
>
> 12.2.5
> T (Trap) Bit--■Bit 0 of byte 64h, static field. This bit, when set to1,
> causes a debug exception (#DB) to occur on a task switch. See "Beakpoint
> Instruction (INT3)" page 340 for additional information.
Yes, I read that before making the patch. But page 340 didn't seem to
give any relevant information.
next prev parent reply other threads:[~2010-10-07 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 21:34 [Qemu-devel] [PATCH 09/11] i386: avoid a write only variable Blue Swirl
2010-10-07 7:27 ` [Qemu-devel] " Paolo Bonzini
2010-10-07 8:27 ` malc
2010-10-07 17:36 ` Blue Swirl [this message]
2010-10-07 17:44 ` malc
2010-10-07 17:32 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikTXnq7N+--tmgZwnimmw31Nv2g97T5KqVWMOQ8@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=av1474@comtv.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).