From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41134 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P3uOq-0001C4-KN for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P3uOn-0004o7-Eo for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:37:00 -0400 Received: from mail-qw0-f45.google.com ([209.85.216.45]:38916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P3uOn-0004nv-A9 for qemu-devel@nongnu.org; Thu, 07 Oct 2010 13:36:57 -0400 Received: by qwk4 with SMTP id 4so181785qwk.4 for ; Thu, 07 Oct 2010 10:36:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <4CAD7657.8080400@redhat.com> From: Blue Swirl Date: Thu, 7 Oct 2010 17:36:36 +0000 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Paolo Bonzini , qemu-devel On Thu, Oct 7, 2010 at 8:27 AM, malc wrote: > On Thu, 7 Oct 2010, Paolo Bonzini wrote: > >> On 10/06/2010 11:34 PM, Blue Swirl wrote: >> > Compiling with GCC 4.6.0 20100925 produced warnings: >> > /src/qemu/target-i386/op_helper.c: In function 'switch_tss': >> > /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' >> > set but not used [-Werror=3Dunused-but-set-variable] >> > >> > Fix by deleting the variable. >> >> Again, this warning tells us the emulation is incorrect, so it's wrong t= o >> remove it. >> > > http://support.amd.com/us/Processor_TechDocs/24593.pdf > > 12.2.5 > T (Trap) Bit--=E2=96=A0Bit 0 of byte 64h, static field. This bit, when se= t to1, > causes a debug exception (#DB) to occur on a task switch. See "Beakpoint > Instruction (INT3)" page 340 for additional information. Yes, I read that before making the patch. But page 340 didn't seem to give any relevant information.