From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58243 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ofxav-0003gX-4P
	for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:10:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OfxXT-0000jv-UD
	for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:06:57 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:60892)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OfxXT-0000jo-S8
	for qemu-devel@nongnu.org; Mon, 02 Aug 2010 12:06:55 -0400
Received: by qyk35 with SMTP id 35so5393741qyk.4
	for <qemu-devel@nongnu.org>; Mon, 02 Aug 2010 09:06:55 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4C5579DA.8050508@reactos.org>
References: <4C5579DA.8050508@reactos.org>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 2 Aug 2010 16:06:35 +0000
Message-ID: <AANLkTikUUKpc9k1wJi3noUOWpcrsb_W+gtJW7m6Xy9YP@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 00/20] MIPS Magnum conversion to qdev
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Herv=C3=A9_Poussineau?= <hpoussin@reactos.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Sun, Aug 1, 2010 at 1:42 PM, Herv=C3=A9 Poussineau <hpoussin@reactos.org=
> wrote:
> This series converts devices used by MIPS Magnum emulation to qdev device=
s.
> Once applied, Magnum emulation will be fully creatable by a configuration
> file (see attached file)
>
> usage:
> qemu-system-mips64el -M empty -nodefaults -readconfig magnum
> -netdev id=3Dnic,type=3Duser
> -drive id=3Ddisk,format=3Dqcow2,if=3Dnone,file=3D1G.qcow2
> -drive id=3Dcdrom,media=3Dcdrom,format=3Draw,if=3Dnone,file=3Darccd.iso
> -chardev id=3Dserial0,backend=3Dvc
> -chardev id=3Dserial1,backend=3Dvc
> -chardev id=3Dparallel0,backend=3Dvc
>
> All feedback is very appreciated.

I appreciate very much your goal to make the devices qdevified.
However, the approach is not correct. Instead of adding 'iobase'
parameters and using cpu_register_physical_memory() in the device
code, you should just use sysbus_mmio_map() at board level. I also
don't see much need for a dedicated rc4030 bus. See for example
syborg.c for a mostly qdevified board.