From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: xen-devel@lists.xensource.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Feiran Zheng <famcool@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] Re: [PATCH]hw/xen_disk: aio_inflight not released in handling ioreq when nr_segments==0
Date: Wed, 9 Mar 2011 15:01:51 +0000 [thread overview]
Message-ID: <AANLkTik_XZBdeT3afgDXJX1h=j5ihbXc44MRO8Y_Eqjr@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103091441540.2968@kaball-desktop>
On Wed, Mar 9, 2011 at 2:42 PM, Stefano Stabellini
<stefano.stabellini@eu.citrix.com> wrote:
> On Wed, 9 Mar 2011, Feiran Zheng wrote:
>> In hw/xen_disk.c, async writing ioreq is leaked when
>> ioreq->req.nr_segments==0, because `aio_inflight` flag is not released
>> properly (skipped by misplaced "break").
>>
>> Signed-off-by: Feiran Zheng <famcool@gmail.com>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Included Kevin so this can be taken up into the block subsystem branch.
Stefan
next prev parent reply other threads:[~2011-03-09 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 13:19 [Qemu-devel] [PATCH]hw/xen_disk: aio_inflight not released in handling ioreq when nr_segments==0 Feiran Zheng
2011-03-09 14:42 ` [Qemu-devel] " Stefano Stabellini
2011-03-09 15:01 ` Stefan Hajnoczi [this message]
2011-03-09 15:54 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTik_XZBdeT3afgDXJX1h=j5ihbXc44MRO8Y_Eqjr@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=famcool@gmail.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).