From: Blue Swirl <blauwirbel@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc
Date: Tue, 1 Feb 2011 18:02:32 +0000 [thread overview]
Message-ID: <AANLkTik_gGJORqYaeCTs6Mfd+2U40p5ei3DdFHS7r42p@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=E0p_Wdd3gRDQisrhqSc=paooBf4b+9m4ZxNQG@mail.gmail.com>
On Tue, Feb 1, 2011 at 4:00 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 1 February 2011 15:54, Peter Maydell <peter.maydell@linaro.org> wrote:
>> --- a/linux-user/signal.c
>> +++ b/linux-user/signal.c
>> @@ -1817,9 +1817,10 @@ struct target_sigcontext {
>> /* A Sparc stack frame */
>> struct sparc_stackf {
>> abi_ulong locals[8];
>> - abi_ulong ins[6];
>> - struct sparc_stackf *fp;
>> - abi_ulong callers_pc;
>> + abi_ulong ins[8];
>> + /* It's simpler to treat fp and callers_pc as elements of ins[]
>> + * since we never need to access them ourselves.
>> + */
>> char *structptr;
>
> Incidentally, I think the presence of a host pointer in a target
> structure definition is a (different) bug which might cause problems
> when the target and host have different pointer sizes...
Right, it was copied from Linux. I can't see where it was used.
UREG_FP use cases look OK.
next prev parent reply other threads:[~2011-02-01 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 15:54 [Qemu-devel] [PATCH] linux-user: avoid gcc array overrun warning for sparc Peter Maydell
2011-02-01 16:00 ` Peter Maydell
2011-02-01 18:02 ` Blue Swirl [this message]
2011-02-01 17:58 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik_gGJORqYaeCTs6Mfd+2U40p5ei3DdFHS7r42p@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).