From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53081 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pwaru-0002pp-Ne
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:53:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Pwars-0002XA-MQ
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:53:02 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:59449)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Pwars-0002Wx-JC
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:53:00 -0500
Received: by yxk8 with SMTP id 8so2021024yxk.4
	for <qemu-devel@nongnu.org>; Mon, 07 Mar 2011 05:52:59 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1299460984-15849-16-git-send-email-aliguori@us.ibm.com>
References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com>
	<1299460984-15849-16-git-send-email-aliguori@us.ibm.com>
Date: Mon, 7 Mar 2011 13:52:59 +0000
Message-ID: <AANLkTikdZta19BsTxmmOnQvB8APCHsPp8HKy8BaSUNN0@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 15/22] qapi: add new QMP server that uses
	CharDriverState
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Adam Litke <aglitke@linux.vnet.ibm.com>

On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori <aliguori@us.ibm.com> wrote=
:
> +static void qmp_chr_send_greeting(QmpSession *s)
> +{
> + =A0 =A0VersionInfo *info;
> + =A0 =A0QObject *vers;
> + =A0 =A0QObject *greeting;
> + =A0 =A0QString *str;
> +
> + =A0 =A0info =3D qmp_query_version(NULL);
> + =A0 =A0vers =3D qmp_marshal_type_VersionInfo(info);
> + =A0 =A0qmp_free_version_info(info);
> +
> + =A0 =A0greeting =3D qobject_from_jsonf("{'QMP': {'version': %p, 'capabi=
lities': []} }",
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0vers=
);
> + =A0 =A0str =3D qobject_to_json(greeting);
> + =A0 =A0qobject_decref(greeting);
> +
> + =A0 =A0qemu_chr_write(s->chr, (void *)str->string, str->length);
> + =A0 =A0qemu_chr_write(s->chr, (void *)"\n", 1);
> + =A0 =A0QDECREF(str);
> +}

Is vers leaked?

Stefan