From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50862 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnF84-0005DV-Tp for qemu-devel@nongnu.org; Sun, 22 Aug 2010 14:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnF83-0004Tv-OC for qemu-devel@nongnu.org; Sun, 22 Aug 2010 14:18:48 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:49211) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnF83-0004Tr-Kc for qemu-devel@nongnu.org; Sun, 22 Aug 2010 14:18:47 -0400 Received: by qyk5 with SMTP id 5so2233752qyk.4 for ; Sun, 22 Aug 2010 11:18:47 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4C71550F.6080602@redhat.com> References: <4C6A4291.1020105@redhat.com> <4C6A8CD8.2080701@codemonkey.ws> <4C71550F.6080602@redhat.com> From: Blue Swirl Date: Sun, 22 Aug 2010 18:18:27 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: Miguel Di Ciurcio Filho , Markus Armbruster , qemu-devel On Sun, Aug 22, 2010 at 4:49 PM, Jes Sorensen wro= te: > On 08/21/10 16:03, Blue Swirl wrote: >> On Sat, Aug 21, 2010 at 12:24 PM, Markus Armbruster = wrote: >>> Could be "fun" for developers using Windows. =C2=A0If they exist. >> >> At least OCaml site offers binary download for Windows. I didn't >> compile Coccinelle myself, so I don't know how much that helps. > > I know nothing about Coccinelle, but I did find that yum knew where to > get it. However, that said, I think we should try to avoid depending on > exotic tools that may not exist on OSes which may be used by developers. > What about OSX? Same thing, binary for OCaml exists. There's none for *BSD or *Solaris, tho= ugh. >>>>> Even a working patch checking tool can only address the last issue >>>>> (haphazard enforcement), not the other ones. =C2=A0You may not care. >>>> >>>> Which other ones? >>> >>> Quoting myself: >>> >>> =C2=A0 =C2=A0[...] =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 the current CODING_STYLE is >>> =C2=A0 =C2=A0idiosyncratic, >> >> Personal preference. I liked Fabrice's style but I also like current >> style. I would probably like Linux style except for the LISPisms. I >> don't like GNU or Java style. > > My favorite quote from the Linux kernel coding style: > "First off, I'd suggest printing out a copy of the GNU coding standards, > and NOT read it. =C2=A0Burn them, it's a great symbolic gesture." :) > >>> While wasting time for historical reasons is certainly better than >>> wasting time for the heck of it, it's arguably worse than stopping the >>> waste. >> >> But how would you do that? Drop the CODING_STYLE (and accept >> anything)? Switch to a new CODING_STYLE that is widely appreciated and >> so all bikeshedding will cease? Enforce current style? > > I would suggest we either clean up the existing rule, or switch to the > Linux kernel style, with the explicit exemption that existing code can > keep the 4-char indentation, unless the whole file is converted. I'd > like to avoid a total reformatting of the codebase, but we could look at > it on a file by file base if it becomes relevant. Sounds reasonable.