From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34273 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OOt6c-0005Qs-JU
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:56:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <corentin.chary@gmail.com>) id 1OOt6a-0003Cw-RF
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:56:38 -0400
Received: from fg-out-1718.google.com ([72.14.220.154]:7102)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <corentin.chary@gmail.com>) id 1OOt6a-0003Cc-IT
	for qemu-devel@nongnu.org; Wed, 16 Jun 2010 09:56:36 -0400
Received: by fg-out-1718.google.com with SMTP id l26so1259813fgb.10
	for <qemu-devel@nongnu.org>; Wed, 16 Jun 2010 06:56:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <m31vc7nmiu.fsf@trasno.mitica>
References: <1276672333-14831-1-git-send-email-corentincj@iksaif.net>
	<1276672333-14831-2-git-send-email-corentincj@iksaif.net>
	<m31vc7nmiu.fsf@trasno.mitica>
Date: Wed, 16 Jun 2010 15:56:34 +0200
Message-ID: <AANLkTikfbFEeBOl1Lt1S13SIECLUbeife0XhULRPNGwj@mail.gmail.com>
From: Corentin Chary <corentin.chary@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH 01/16] vnc: tight: add JPEG and gradient
	subencoding with smooth image detection
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Wed, Jun 16, 2010 at 3:18 PM, Juan Quintela <quintela@redhat.com> wrote:
> Corentin Chary <corentincj@iksaif.net> wrote:
>> Add gradient filter and JPEG compression with an heuristic to detect how
>> lossy the comppression will be. This code has been adapted from
>> libvncserver/tight.c.
>>
>> JPEG support can be enabled/disabled at compile time with --enable-vnc-j=
peg
>> and --disable-vnc-jpeg.
>>
>> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
>> ---
>> =A0Makefile.target =A0 =A0 =A0| =A0 =A01 +
>> =A0configure =A0 =A0 =A0 =A0 =A0 =A0| =A0 33 +++
>> =A0vnc-encoding-tight.c | =A0559 +++++++++++++++++++++++++++++++++++++++=
++++++++++-
>> =A0vnc-encoding-tight.h | =A0 =A05 +
>> =A0vnc.h =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A04 +
>> =A05 files changed, 601 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 478b89d..d9e888a 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -177,6 +177,7 @@ LIBS+=3D-lz
>>
>> =A0QEMU_CFLAGS +=3D $(VNC_TLS_CFLAGS)
>> =A0QEMU_CFLAGS +=3D $(VNC_SASL_CFLAGS)
>> +QEMU_CFLAGS +=3D $(VNC_JPEG_CFLAGS)
>>
>> =A0# xen backend driver support
>> =A0obj-$(CONFIG_XEN) +=3D xen_machine_pv.o xen_domainbuild.o
>> diff --git a/configure b/configure
>> index c0d8aa5..304b4b0 100755
>> --- a/configure
>> +++ b/configure
>> @@ -268,6 +268,7 @@ uuid=3D""
>> =A0vde=3D""
>> =A0vnc_tls=3D""
>> =A0vnc_sasl=3D""
>> +vnc_jpeg=3D""
>
> init it to "no"
>
>> =A0xen=3D""
>> =A0linux_aio=3D""
>> =A0vhost_net=3D""
>
>> =A0##########################################
>> +# VNC JPEG detection
>> +if test "$vnc_jpeg" =3D "yes" ; then
>
> and use here !=3D "no" as a test as the rest of the conditions, that way
> you only need to look in one place to know what is the default.
>

I guess the same thing apply to PNG and Threaded server. Would it be
ok to send a cumulative patch to fix that ?
Thanks,

--=20
Corentin Chary
http://xf.iksaif.net