From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39686 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFpKm-0001ND-Nf for qemu-devel@nongnu.org; Sat, 22 May 2010 10:05:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFpKk-0001CO-9S for qemu-devel@nongnu.org; Sat, 22 May 2010 10:05:48 -0400 Received: from mail-px0-f173.google.com ([209.85.212.173]:52394) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFpKj-0001CC-VA for qemu-devel@nongnu.org; Sat, 22 May 2010 10:05:46 -0400 Received: by pxi19 with SMTP id 19so870689pxi.4 for ; Sat, 22 May 2010 07:05:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Blue Swirl Date: Sat, 22 May 2010 14:05:24 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH v2 00/15] Basic device state visualization Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Juan Quintela , qemu-devel@nongnu.org, Markus Armbruster , Luiz Capitulino , Avi Kivity On Sat, May 22, 2010 at 8:17 AM, Jan Kiszka wrote: > Here is version 2 of the device_show patch series. It currently has some > dependencies on recently posted doc changes / enhancements, namely: > =C2=A0- http://thread.gmane.org/gmane.comp.emulators.qemu/70673 > =C2=A0 ([PATCH v3 0/3]: QMP: Commands doc) > =C2=A0- http://thread.gmane.org/gmane.comp.emulators.qemu/70756 > =C2=A0 ([PATCH 1/7] QMP: Add "Downstream extension of QMP" to spec) I had minor comments to 8/15, otherwise looks good. > > Major changes in v2 are: > =C2=A0- command line completion for device tree paths > =C2=A0- introduced complex object classes ("__class__") and applied that = on > =C2=A0 buffers > =C2=A0- documentation > =C2=A0- applied new qdev path specification also on device_del > =C2=A0- proper qdev device/bus sorting via QTAILQ (instead of QLIST_INSER= T_TAIL) > =C2=A0- added QERR_DEVICE_NO_STATE > =C2=A0- fixed various bugs > =C2=A0- > > For reference, the series is also available at > > =C2=A0 =C2=A0 =C2=A0 =C2=A0git://git.kiszka.org/qemu.git queues/device-sh= ow > > Thanks for all comments so far! > > Jan Kiszka (15): > =C2=A0Add dependency of JSON unit tests on config-host.h > =C2=A0qdev: Fix scanning across single-bus devices > =C2=A0qdev: Allow device addressing via 'driver.instance' > =C2=A0qdev: Convert device and bus lists to QTAILQ > =C2=A0qdev: Allow device specification by qtree path for device_del > =C2=A0qdev: Push QMP mode checks into qbus_list_bus/dev > =C2=A0monitor: Add completion for qdev paths > =C2=A0Add base64 encoder/decoder > =C2=A0QMP: Reserve namespace for complex object classes > =C2=A0Add QBuffer > =C2=A0monitor: return length of printed string via monitor_[v]printf > =C2=A0monitor: Add basic device state visualization > =C2=A0QMP: Teach basic capability negotiation to python example > =C2=A0QMP: Fix python helper /wrt long return strings > =C2=A0QMP: Add support for buffer class to qmp python helper > > =C2=A0Makefile =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 =C2=A05 +- > =C2=A0Makefile.objs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2= =A04 +- > =C2=A0QMP/qmp-shell =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2= =A01 + > =C2=A0QMP/qmp-spec.txt =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 24 +++- > =C2=A0QMP/qmp.py =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2= =A0 29 +++- > =C2=A0QMP/vm-info =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2= =A0 =C2=A01 + > =C2=A0base64.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0202 +++++++++++++++++++++++ > =C2=A0base64.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 18 ++ > =C2=A0check-qbuffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0172 +++++= ++++++++++++++ > =C2=A0configure =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0 =C2=A02 +- > =C2=A0docs/qdev-device-use.txt | =C2=A0 16 ++- > =C2=A0hw/acpi_piix4.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A02 = +- > =C2=A0hw/hw.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| =C2=A0 =C2=A02 + > =C2=A0hw/i2c.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 =C2=A02 +- > =C2=A0hw/pci-hotplug.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A02 +- > =C2=A0hw/qdev.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0408 +++++++++++++++++++++++++++++++++++++++++----- > =C2=A0hw/qdev.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0 12 +- > =C2=A0hw/ssi.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 =C2=A06 +- > =C2=A0monitor.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0108 +++++++++++- > =C2=A0monitor.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0 =C2=A04 +- > =C2=A0qbuffer.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0116 +++++++++++++ > =C2=A0qbuffer.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0 33 ++++ > =C2=A0qemu-monitor.hx =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 74 +++++= +++- > =C2=A0qemu-tool.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2= =A0 =C2=A06 +- > =C2=A0qerror.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 =C2=A04 + > =C2=A0qerror.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | = =C2=A0 =C2=A03 + > =C2=A0qjson.c =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| =C2=A0 15 ++ > =C2=A0qobject.h =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| = =C2=A0 =C2=A01 + > =C2=A028 files changed, 1193 insertions(+), 79 deletions(-) > =C2=A0create mode 100644 base64.c > =C2=A0create mode 100644 base64.h > =C2=A0create mode 100644 check-qbuffer.c > =C2=A0create mode 100644 qbuffer.c > =C2=A0create mode 100644 qbuffer.h > > >