* [Qemu-devel] [PATCH RESEND v3] fix vnc regression
@ 2011-03-11 9:10 Wen Congyang
2011-03-22 14:02 ` [Qemu-devel] " Anthony Liguori
2011-03-22 16:28 ` Anthony Liguori
0 siblings, 2 replies; 5+ messages in thread
From: Wen Congyang @ 2011-03-11 9:10 UTC (permalink / raw)
To: qemu-devel, Stefan Weil, Corentin Chary, Anthony Liguori
This patch fix the following regression:
1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits().
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
ui/vnc.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 34dc0cd..8fd35c1 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1645,17 +1645,21 @@ static void framebuffer_update_request(VncState *vs, int incremental,
int x_position, int y_position,
int w, int h)
{
+ int i;
+ const size_t width = ds_get_width(vs->ds) / 16;
+
if (y_position > ds_get_height(vs->ds))
y_position = ds_get_height(vs->ds);
if (y_position + h >= ds_get_height(vs->ds))
h = ds_get_height(vs->ds) - y_position;
- int i;
vs->need_update = 1;
if (!incremental) {
vs->force_update = 1;
for (i = 0; i < h; i++) {
- bitmap_set(vs->dirty[y_position + i], x_position / 16, w / 16);
+ bitmap_set(vs->dirty[y_position + i], 0, width);
+ bitmap_clear(vs->dirty[y_position + i], width,
+ VNC_DIRTY_WORDS * BITS_PER_LONG - width);
}
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH RESEND v3] fix vnc regression
2011-03-11 9:10 [Qemu-devel] [PATCH RESEND v3] fix vnc regression Wen Congyang
@ 2011-03-22 14:02 ` Anthony Liguori
2011-03-22 14:04 ` Corentin Chary
2011-03-22 16:28 ` Anthony Liguori
1 sibling, 1 reply; 5+ messages in thread
From: Anthony Liguori @ 2011-03-22 14:02 UTC (permalink / raw)
To: Wen Congyang; +Cc: qemu-devel, Corentin Chary
On 03/11/2011 03:10 AM, Wen Congyang wrote:
> This patch fix the following regression:
> 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits().
>
> Signed-off-by: Wen Congyang<wency@cn.fujitsu.com>
>
> ---
> ui/vnc.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 34dc0cd..8fd35c1 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -1645,17 +1645,21 @@ static void framebuffer_update_request(VncState *vs, int incremental,
> int x_position, int y_position,
> int w, int h)
> {
> + int i;
> + const size_t width = ds_get_width(vs->ds) / 16;
> +
> if (y_position> ds_get_height(vs->ds))
> y_position = ds_get_height(vs->ds);
> if (y_position + h>= ds_get_height(vs->ds))
> h = ds_get_height(vs->ds) - y_position;
>
> - int i;
> vs->need_update = 1;
> if (!incremental) {
> vs->force_update = 1;
> for (i = 0; i< h; i++) {
> - bitmap_set(vs->dirty[y_position + i], x_position / 16, w / 16);
> + bitmap_set(vs->dirty[y_position + i], 0, width);
> + bitmap_clear(vs->dirty[y_position + i], width,
> + VNC_DIRTY_WORDS * BITS_PER_LONG - width);
> }
VNC_DIRTY_WORDS in not a valid symbol in the latest tip.
Regards,
Anthony Liguori
> }
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] Re: [PATCH RESEND v3] fix vnc regression
2011-03-11 9:10 [Qemu-devel] [PATCH RESEND v3] fix vnc regression Wen Congyang
2011-03-22 14:02 ` [Qemu-devel] " Anthony Liguori
@ 2011-03-22 16:28 ` Anthony Liguori
1 sibling, 0 replies; 5+ messages in thread
From: Anthony Liguori @ 2011-03-22 16:28 UTC (permalink / raw)
To: Wen Congyang; +Cc: qemu-devel, Corentin Chary
On 03/11/2011 03:10 AM, Wen Congyang wrote:
> This patch fix the following regression:
> 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits().
>
> Signed-off-by: Wen Congyang<wency@cn.fujitsu.com>
Applied (version that used VNC_DIRTY_BITS). Thanks.
Regards,
Anthony Liguori
> ---
> ui/vnc.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index 34dc0cd..8fd35c1 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -1645,17 +1645,21 @@ static void framebuffer_update_request(VncState *vs, int incremental,
> int x_position, int y_position,
> int w, int h)
> {
> + int i;
> + const size_t width = ds_get_width(vs->ds) / 16;
> +
> if (y_position> ds_get_height(vs->ds))
> y_position = ds_get_height(vs->ds);
> if (y_position + h>= ds_get_height(vs->ds))
> h = ds_get_height(vs->ds) - y_position;
>
> - int i;
> vs->need_update = 1;
> if (!incremental) {
> vs->force_update = 1;
> for (i = 0; i< h; i++) {
> - bitmap_set(vs->dirty[y_position + i], x_position / 16, w / 16);
> + bitmap_set(vs->dirty[y_position + i], 0, width);
> + bitmap_clear(vs->dirty[y_position + i], width,
> + VNC_DIRTY_WORDS * BITS_PER_LONG - width);
> }
> }
> }
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-22 16:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-11 9:10 [Qemu-devel] [PATCH RESEND v3] fix vnc regression Wen Congyang
2011-03-22 14:02 ` [Qemu-devel] " Anthony Liguori
2011-03-22 14:04 ` Corentin Chary
2011-03-22 14:09 ` Anthony Liguori
2011-03-22 16:28 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).