From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55337 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAjex-0003ik-Dn for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:33:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAjet-0002DC-Bs for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:33:51 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:54338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAjet-0002Cp-6v for qemu-devel@nongnu.org; Tue, 26 Oct 2010 09:33:47 -0400 Received: by bwz2 with SMTP id 2so4154453bwz.4 for ; Tue, 26 Oct 2010 06:33:46 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <4CC6C5A7.5020106@redhat.com> References: <4CC6C5A7.5020106@redhat.com> From: Roy Tam Date: Tue, 26 Oct 2010 21:33:26 +0800 Message-ID: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH] QEMU_OPTION_spice is not guarded by ifdef List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel 2010/10/26 Gerd Hoffmann : > On 10/26/10 13:33, Roy Tam wrote: >> >> Hi all, >> >> commit 29b0040be6371c403dae0fef7fec36b814e300e8 breaks building when >> "--disable-spice" configure switch is used. The following patch fix >> this. > > Huh? =A0It builds fine for me. =A0What build failure do you get? > I did a "make clean" before but I am still getting error about QEMU_OPTION_spice. Log: (...) LINK qemu-io.exe GEN libhw32/qemu-options.def CC libhw32/vl.o C:/msys/home/User/qemu/vl.c: In function `qemu_main': C:/msys/home/User/qemu/vl.c:2601: error: `QEMU_OPTION_spice' undeclared (first use in this function) C:/msys/home/User/qemu/vl.c:2601: error: (Each undeclared identifier is reported only once C:/msys/home/User/qemu/vl.c:2601: error: for each function it appears in.) make[1]: *** [vl.o] Error 1 make: *** [subdir-libhw32] Error 2 > cheers, > =A0Gerd > > >