From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54703 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PCz8S-00044t-DU
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:29:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PCz8R-0003ID-7L
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:29:36 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:59148)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1PCz8R-0003Hm-3D
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 14:29:35 -0400
Received: by ywa8 with SMTP id 8so3151184ywa.4
	for <qemu-devel@nongnu.org>; Mon, 01 Nov 2010 11:29:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1288623713-28062-3-git-send-email-agraf@suse.de>
References: <1288623713-28062-1-git-send-email-agraf@suse.de>
	<1288623713-28062-3-git-send-email-agraf@suse.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Mon, 1 Nov 2010 18:29:13 +0000
Message-ID: <AANLkTiksFJ78Tid9MLHNyvxbKe4K3eBjgUf=1Lt8UkOK@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On Mon, Nov 1, 2010 at 3:01 PM, Alexander Graf <agraf@suse.de> wrote:
> ---
> =C2=A0hw/elf_ops.h | =C2=A0 61 ++++++++++++++++++++++++++++++++++++++++++=
+++++++++++++++-
> =C2=A0hw/loader.c =C2=A0| =C2=A0 =C2=A07 ++++++
> =C2=A0hw/loader.h =C2=A0| =C2=A0 =C2=A03 ++
> =C2=A03 files changed, 70 insertions(+), 1 deletions(-)
>
> diff --git a/hw/elf_ops.h b/hw/elf_ops.h
> index 8b63dfc..645d058 100644
> --- a/hw/elf_ops.h
> +++ b/hw/elf_ops.h
> @@ -189,6 +189,44 @@ static int glue(load_symbols, SZ)(struct elfhdr *ehd=
r, int fd, int must_swab,
> =C2=A0 =C2=A0 return -1;
> =C2=A0}
>
> +static void glue(elf_read_notes, SZ)(uint8_t *data, int data_len,
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ElfHandlers *handle=
rs, int must_swab)
> +{
> + =C2=A0 =C2=A0uint8_t *p =3D data;
> +
> + =C2=A0 =C2=A0while ((ulong)&p[3] < (ulong)&data[data_len]) {

Please use 'unsigned long'.