From: Corentin Chary <corentin.chary@gmail.com>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings
Date: Tue, 18 May 2010 11:56:40 +0200 [thread overview]
Message-ID: <AANLkTiksGH6KIV1A8HJoWv4caM5auBkWQLa5hyVUYqCZ@mail.gmail.com> (raw)
In-Reply-To: <CAD47FAF-F04F-4EB9-AE2D-3711826635F8@suse.de>
On Tue, May 18, 2010 at 11:18 AM, Alexander Graf <agraf@suse.de> wrote:
>
> On 18.05.2010, at 09:31, Corentin Chary wrote:
>
> This is missing a patch description. When people later on either cherry-pick your commits or simply git show them, it's almost impossible to know what's going on.
> So please always put in a patch description.
>
>
> Alex
>
In this case, the description is all in the subject and the patch is
pretty obvious.
Should I really add something like "Create a new set_encoding()
function to remove duplicate code in set_encodings()." ?
--
Corentin Chary
http://xf.iksaif.net
next prev parent reply other threads:[~2010-05-18 9:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 7:31 [Qemu-devel] (no subject) Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 01/10] vnc: refactor set_encodings Corentin Chary
2010-05-18 9:18 ` [Qemu-devel] " Alexander Graf
2010-05-18 9:56 ` Corentin Chary [this message]
2010-05-18 9:58 ` Alexander Graf
2010-05-18 9:19 ` Alexander Graf
2010-05-18 9:53 ` Corentin Chary
2010-05-18 9:56 ` Alexander Graf
2010-05-18 7:31 ` [Qemu-devel] [PATCH 02/10] vnc: really call zlib if we want zlib Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 03/10] vnc: only use a single zlib stream Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 04/10] vnc: adjust compression zstream level Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 05/10] vnc: add basic tight support Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 06/10] vnc: add support for tight fill encoding Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 07/10] vnc: don't clear zlib stream on set_encoding Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 08/10] vnc: remove memory leaks in zlib and tight encoding Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 09/10] vnc: tight: add palette encoding Corentin Chary
2010-05-18 7:31 ` [Qemu-devel] [PATCH 10/10] vnc: update copyrights for vnc-encoding-tight.c Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTiksGH6KIV1A8HJoWv4caM5auBkWQLa5hyVUYqCZ@mail.gmail.com \
--to=corentin.chary@gmail.com \
--cc=agl@us.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).