From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58745 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OEJXf-0007Ku-OH for qemu-devel@nongnu.org; Tue, 18 May 2010 05:56:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OEJXY-0006Hi-OC for qemu-devel@nongnu.org; Tue, 18 May 2010 05:56:51 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:55636) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OEJXX-0006HM-Og for qemu-devel@nongnu.org; Tue, 18 May 2010 05:56:44 -0400 Received: by fxm17 with SMTP id 17so2129123fxm.4 for ; Tue, 18 May 2010 02:56:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1274167881-6966-1-git-send-email-corentincj@iksaif.net> <1274167881-6966-2-git-send-email-corentincj@iksaif.net> Date: Tue, 18 May 2010 11:56:40 +0200 Message-ID: Subject: Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings From: Corentin Chary Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Anthony Liguori , qemu-devel@nongnu.org, Adam Litke On Tue, May 18, 2010 at 11:18 AM, Alexander Graf wrote: > > On 18.05.2010, at 09:31, Corentin Chary wrote: > > This is missing a patch description. When people later on either cherry-pick your commits or simply git show them, it's almost impossible to know what's going on. > So please always put in a patch description. > > > Alex > In this case, the description is all in the subject and the patch is pretty obvious. Should I really add something like "Create a new set_encoding() function to remove duplicate code in set_encodings()." ? -- Corentin Chary http://xf.iksaif.net