From: Stefan Hajnoczi <stefanha@gmail.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail
Date: Sat, 2 Apr 2011 14:48:14 +0100 [thread overview]
Message-ID: <AANLkTiku1WJgZ7dWNvZydapi-jCrHCRb88F7=0a5=gVB@mail.gmail.com> (raw)
In-Reply-To: <4D960A7E.5060503@linux.vnet.ibm.com>
On Fri, Apr 1, 2011 at 6:25 PM, Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> On 04/01/2011 12:01 PM, Stefan Hajnoczi wrote:
>>
>> On Fri, Apr 01, 2011 at 11:55:39AM -0500, Michael Roth wrote:
>>>
>>> I'd prefer to only document "strict" guidelines, and treat
>>> checkpatch.pl warnings ("suggestions") as an extra "reward" you get
>>> for taking the time to run it.
>>
>> I don't want to be punished for running checkpatch.pl like I'm supposed
>> to while those who don't can get away with more.
>
> You're not! These are extra morsels of goodness :)
>
>>
>> A --pedantic mode would be fine although probably no one besides the
>> author would use it :).
>
> True :) But you're right, this is probably the better approach. How bout:
>
> --warnings: print coding style warnings in addition to errors, and exit
> failure if encountered
>
> Then default to suppressing warning statements, and --no-fail-on-warn
> behavior.
Sounds good to me :).
Stefan
prev parent reply other threads:[~2011-04-02 13:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 15:20 [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail Michael Roth
2011-04-01 15:20 ` [Qemu-devel] [PATCH 1/2] checkpatch.pl: add --no-fail-on-warn option Michael Roth
2011-04-01 15:20 ` [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error Michael Roth
2011-04-01 15:33 ` [Qemu-devel] " Michael Roth
2011-04-01 15:49 ` [Qemu-devel] " Stefan Hajnoczi
2011-04-01 18:46 ` Blue Swirl
2011-04-02 14:02 ` Stefan Hajnoczi
2011-04-01 15:52 ` [Qemu-devel] checkpatch.pl: warn on C99 comments, but don't fail Peter Maydell
2011-04-01 15:59 ` Stefan Hajnoczi
2011-04-01 16:16 ` Peter Maydell
2011-04-01 16:55 ` Michael Roth
2011-04-01 16:58 ` Peter Maydell
2011-04-01 17:24 ` Michael Roth
2011-04-01 17:01 ` Stefan Hajnoczi
2011-04-01 17:25 ` Michael Roth
2011-04-02 13:48 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTiku1WJgZ7dWNvZydapi-jCrHCRb88F7=0a5=gVB@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).