From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48292 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PFZVC-0005Pv-Gk
	for qemu-devel@nongnu.org; Mon, 08 Nov 2010 16:43:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PFZIA-0006SP-I4
	for qemu-devel@nongnu.org; Mon, 08 Nov 2010 16:30:19 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:63281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1PFZIA-0006S5-Df
	for qemu-devel@nongnu.org; Mon, 08 Nov 2010 16:30:18 -0500
Received: by wwb29 with SMTP id 29so500820wwb.10
	for <qemu-devel@nongnu.org>; Mon, 08 Nov 2010 13:30:17 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <AANLkTim_CtM74Gwjc34irunFOqqX4gPoWOCeCj6qWbRC@mail.gmail.com>
References: <1289209443-2528-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<AANLkTim_CtM74Gwjc34irunFOqqX4gPoWOCeCj6qWbRC@mail.gmail.com>
Date: Mon, 8 Nov 2010 21:30:16 +0000
Message-ID: <AANLkTikuPFzM-hC=BzJMZ8BYPNr7aFDMK1cEUYiooWCg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] trace: Trace SCSI request lifecycle
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On Mon, Nov 8, 2010 at 7:18 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Mon, Nov 8, 2010 at 9:44 AM, Stefan Hajnoczi
> <stefanha@linux.vnet.ibm.com> wrote:
>> This patch adds trace events for SCSI request allocation, freeing, CDB
>> parsing, read, and write. =A0These trace events can be used to instrumen=
t
>> the SCSI request lifecycle.
>
> How about converting also the DPRINTFs in hw/scsi-disk.c to tracepoints?

Good idea.  I don't understand the SCSI emulation well enough to trace
the rest, so I couldn't do much besides a mechanical conversion.

Stefan