* [Qemu-devel] [PATCH] [sparc32] fix last cpu timer initialization
@ 2010-08-02 17:58 Artyom Tarasenko
2010-08-02 20:56 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Artyom Tarasenko @ 2010-08-02 17:58 UTC (permalink / raw)
To: qemu-devel; +Cc: blauwirbel, Artyom Tarasenko
The timer #0 is the system timer, so the timer #num_cpu is the
timer of the last CPU, and it must be initialized in slavio_timer_reset.
Don't mark non-existing timers as running.
---
hw/slavio_timer.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c
index d787553..c125de4 100644
--- a/hw/slavio_timer.c
+++ b/hw/slavio_timer.c
@@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d)
curr_timer->limit = 0;
curr_timer->count = 0;
curr_timer->reached = 0;
- if (i < s->num_cpus) {
+ if (i <= s->num_cpus) {
ptimer_set_limit(curr_timer->timer,
LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
ptimer_run(curr_timer->timer, 0);
+ curr_timer->running = 1;
}
- curr_timer->running = 1;
}
s->cputimer_mode = 0;
}
--
1.6.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization
2010-08-02 17:58 [Qemu-devel] [PATCH] [sparc32] fix last cpu timer initialization Artyom Tarasenko
@ 2010-08-02 20:56 ` Blue Swirl
2010-08-02 21:44 ` Artyom Tarasenko
0 siblings, 1 reply; 6+ messages in thread
From: Blue Swirl @ 2010-08-02 20:56 UTC (permalink / raw)
To: Artyom Tarasenko; +Cc: qemu-devel, Artyom Tarasenko
Thanks, applied. Please remember to use Signed-off-by tag.
On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko
<atar4qemu@googlemail.com> wrote:
> The timer #0 is the system timer, so the timer #num_cpu is the
> timer of the last CPU, and it must be initialized in slavio_timer_reset.
>
> Don't mark non-existing timers as running.
> ---
> hw/slavio_timer.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c
> index d787553..c125de4 100644
> --- a/hw/slavio_timer.c
> +++ b/hw/slavio_timer.c
> @@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d)
> curr_timer->limit = 0;
> curr_timer->count = 0;
> curr_timer->reached = 0;
> - if (i < s->num_cpus) {
> + if (i <= s->num_cpus) {
> ptimer_set_limit(curr_timer->timer,
> LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
> ptimer_run(curr_timer->timer, 0);
> + curr_timer->running = 1;
> }
> - curr_timer->running = 1;
> }
> s->cputimer_mode = 0;
> }
> --
> 1.6.2.5
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization
2010-08-02 20:56 ` [Qemu-devel] " Blue Swirl
@ 2010-08-02 21:44 ` Artyom Tarasenko
2010-08-06 16:51 ` Artyom Tarasenko
0 siblings, 1 reply; 6+ messages in thread
From: Artyom Tarasenko @ 2010-08-02 21:44 UTC (permalink / raw)
To: Blue Swirl, Anthony Liguori; +Cc: qemu-devel
Btw, it would be nice to get this patch applied for 0.13: it's a pure
fix, and it allows running the OBP v2.10 for LX and some older OBP
versions for SS-20 too.
2010/8/2 Blue Swirl <blauwirbel@gmail.com>:
> Thanks, applied. Please remember to use Signed-off-by tag.
Grrr. Git 1.6.2.5 seems to ignore the option signoff = true in the
config file. I'll update my git right now.
>
>
> On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko
> <atar4qemu@googlemail.com> wrote:
>> The timer #0 is the system timer, so the timer #num_cpu is the
>> timer of the last CPU, and it must be initialized in slavio_timer_reset.
>>
>> Don't mark non-existing timers as running.
>> ---
>> hw/slavio_timer.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c
>> index d787553..c125de4 100644
>> --- a/hw/slavio_timer.c
>> +++ b/hw/slavio_timer.c
>> @@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d)
>> curr_timer->limit = 0;
>> curr_timer->count = 0;
>> curr_timer->reached = 0;
>> - if (i < s->num_cpus) {
>> + if (i <= s->num_cpus) {
>> ptimer_set_limit(curr_timer->timer,
>> LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
>> ptimer_run(curr_timer->timer, 0);
>> + curr_timer->running = 1;
>> }
>> - curr_timer->running = 1;
>> }
>> s->cputimer_mode = 0;
>> }
>> --
>> 1.6.2.5
>>
>>
>
--
Regards,
Artyom Tarasenko
solaris/sparc under qemu blog: http://tyom.blogspot.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization
2010-08-02 21:44 ` Artyom Tarasenko
@ 2010-08-06 16:51 ` Artyom Tarasenko
2010-08-13 20:29 ` Artyom Tarasenko
0 siblings, 1 reply; 6+ messages in thread
From: Artyom Tarasenko @ 2010-08-06 16:51 UTC (permalink / raw)
To: Blue Swirl, Anthony Liguori; +Cc: qemu-devel
2010/8/2 Artyom Tarasenko <atar4qemu@googlemail.com>:
> Btw, it would be nice to get this patch applied for 0.13: it's a pure
> fix, and it allows running the OBP v2.10 for LX and some older OBP
> versions for SS-20 too.
ping? Objections?
> 2010/8/2 Blue Swirl <blauwirbel@gmail.com>:
>> Thanks, applied. Please remember to use Signed-off-by tag.
>
> Grrr. Git 1.6.2.5 seems to ignore the option signoff = true in the
> config file. I'll update my git right now.
>
>>
>>
>> On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko
>> <atar4qemu@googlemail.com> wrote:
>>> The timer #0 is the system timer, so the timer #num_cpu is the
>>> timer of the last CPU, and it must be initialized in slavio_timer_reset.
>>>
>>> Don't mark non-existing timers as running.
>>> ---
>>> hw/slavio_timer.c | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c
>>> index d787553..c125de4 100644
>>> --- a/hw/slavio_timer.c
>>> +++ b/hw/slavio_timer.c
>>> @@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d)
>>> curr_timer->limit = 0;
>>> curr_timer->count = 0;
>>> curr_timer->reached = 0;
>>> - if (i < s->num_cpus) {
>>> + if (i <= s->num_cpus) {
>>> ptimer_set_limit(curr_timer->timer,
>>> LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
>>> ptimer_run(curr_timer->timer, 0);
>>> + curr_timer->running = 1;
>>> }
>>> - curr_timer->running = 1;
>>> }
>>> s->cputimer_mode = 0;
>>> }
>>> --
>>> 1.6.2.5
>>>
>>>
>>
--
Regards,
Artyom Tarasenko
solaris/sparc under qemu blog: http://tyom.blogspot.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization
2010-08-06 16:51 ` Artyom Tarasenko
@ 2010-08-13 20:29 ` Artyom Tarasenko
2010-08-15 9:59 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Artyom Tarasenko @ 2010-08-13 20:29 UTC (permalink / raw)
To: Blue Swirl, Anthony Liguori; +Cc: qemu-devel
2010/8/6 Artyom Tarasenko <atar4qemu@googlemail.com>:
> 2010/8/2 Artyom Tarasenko <atar4qemu@googlemail.com>:
>> Btw, it would be nice to get this patch applied for 0.13: it's a pure
>> fix, and it allows running the OBP v2.10 for LX and some older OBP
>> versions for SS-20 too.
>
> ping? Objections?
>
No feedback? Are 0.13 patches only accepted with "0.13" in the subject
line? Are sparc patches generally not welcome for the stable release?
>> 2010/8/2 Blue Swirl <blauwirbel@gmail.com>:
>>> Thanks, applied. Please remember to use Signed-off-by tag.
>>
>> Grrr. Git 1.6.2.5 seems to ignore the option signoff = true in the
>> config file. I'll update my git right now.
>>
>>>
>>>
>>> On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko
>>> <atar4qemu@googlemail.com> wrote:
>>>> The timer #0 is the system timer, so the timer #num_cpu is the
>>>> timer of the last CPU, and it must be initialized in slavio_timer_reset.
>>>>
>>>> Don't mark non-existing timers as running.
>>>> ---
>>>> hw/slavio_timer.c | 4 ++--
>>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c
>>>> index d787553..c125de4 100644
>>>> --- a/hw/slavio_timer.c
>>>> +++ b/hw/slavio_timer.c
>>>> @@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d)
>>>> curr_timer->limit = 0;
>>>> curr_timer->count = 0;
>>>> curr_timer->reached = 0;
>>>> - if (i < s->num_cpus) {
>>>> + if (i <= s->num_cpus) {
>>>> ptimer_set_limit(curr_timer->timer,
>>>> LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
>>>> ptimer_run(curr_timer->timer, 0);
>>>> + curr_timer->running = 1;
>>>> }
>>>> - curr_timer->running = 1;
>>>> }
>>>> s->cputimer_mode = 0;
>>>> }
>>>> --
>>>> 1.6.2.5
>>>>
>>>>
>>>
>
>
> --
> Regards,
> Artyom Tarasenko
>
> solaris/sparc under qemu blog: http://tyom.blogspot.com/
>
--
Regards,
Artyom Tarasenko
solaris/sparc under qemu blog: http://tyom.blogspot.com/
^ permalink raw reply [flat|nested] 6+ messages in thread* [Qemu-devel] Re: [PATCH] [sparc32] fix last cpu timer initialization
2010-08-13 20:29 ` Artyom Tarasenko
@ 2010-08-15 9:59 ` Blue Swirl
0 siblings, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2010-08-15 9:59 UTC (permalink / raw)
To: Artyom Tarasenko; +Cc: qemu-devel
On Fri, Aug 13, 2010 at 8:29 PM, Artyom Tarasenko
<atar4qemu@googlemail.com> wrote:
> 2010/8/6 Artyom Tarasenko <atar4qemu@googlemail.com>:
>> 2010/8/2 Artyom Tarasenko <atar4qemu@googlemail.com>:
>>> Btw, it would be nice to get this patch applied for 0.13: it's a pure
>>> fix, and it allows running the OBP v2.10 for LX and some older OBP
>>> versions for SS-20 too.
>>
>> ping? Objections?
>>
>
> No feedback? Are 0.13 patches only accepted with "0.13" in the subject
> line? Are sparc patches generally not welcome for the stable release?
This depends on 0.13 release strategy. I suppose that there will be
another -rc, but it can be based on master or it can be based on -rc0
with cherry picking from master.
>>> 2010/8/2 Blue Swirl <blauwirbel@gmail.com>:
>>>> Thanks, applied. Please remember to use Signed-off-by tag.
>>>
>>> Grrr. Git 1.6.2.5 seems to ignore the option signoff = true in the
>>> config file. I'll update my git right now.
>>>
>>>>
>>>>
>>>> On Mon, Aug 2, 2010 at 5:58 PM, Artyom Tarasenko
>>>> <atar4qemu@googlemail.com> wrote:
>>>>> The timer #0 is the system timer, so the timer #num_cpu is the
>>>>> timer of the last CPU, and it must be initialized in slavio_timer_reset.
>>>>>
>>>>> Don't mark non-existing timers as running.
>>>>> ---
>>>>> hw/slavio_timer.c | 4 ++--
>>>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/hw/slavio_timer.c b/hw/slavio_timer.c
>>>>> index d787553..c125de4 100644
>>>>> --- a/hw/slavio_timer.c
>>>>> +++ b/hw/slavio_timer.c
>>>>> @@ -377,12 +377,12 @@ static void slavio_timer_reset(DeviceState *d)
>>>>> curr_timer->limit = 0;
>>>>> curr_timer->count = 0;
>>>>> curr_timer->reached = 0;
>>>>> - if (i < s->num_cpus) {
>>>>> + if (i <= s->num_cpus) {
>>>>> ptimer_set_limit(curr_timer->timer,
>>>>> LIMIT_TO_PERIODS(TIMER_MAX_COUNT32), 1);
>>>>> ptimer_run(curr_timer->timer, 0);
>>>>> + curr_timer->running = 1;
>>>>> }
>>>>> - curr_timer->running = 1;
>>>>> }
>>>>> s->cputimer_mode = 0;
>>>>> }
>>>>> --
>>>>> 1.6.2.5
>>>>>
>>>>>
>>>>
>>
>>
>> --
>> Regards,
>> Artyom Tarasenko
>>
>> solaris/sparc under qemu blog: http://tyom.blogspot.com/
>>
>
>
>
> --
> Regards,
> Artyom Tarasenko
>
> solaris/sparc under qemu blog: http://tyom.blogspot.com/
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-15 9:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-02 17:58 [Qemu-devel] [PATCH] [sparc32] fix last cpu timer initialization Artyom Tarasenko
2010-08-02 20:56 ` [Qemu-devel] " Blue Swirl
2010-08-02 21:44 ` Artyom Tarasenko
2010-08-06 16:51 ` Artyom Tarasenko
2010-08-13 20:29 ` Artyom Tarasenko
2010-08-15 9:59 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).