From: Blue Swirl <blauwirbel@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 0/2] pckbd improvements
Date: Mon, 17 May 2010 19:34:23 +0300 [thread overview]
Message-ID: <AANLkTikyt3ktLW7t3LV3kpzuQfdCVREytquIFfOrHnV7@mail.gmail.com> (raw)
In-Reply-To: <358077571.976941274095016450.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
On 5/17/10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > > > In 2/2, A20 logic changes a bit but I doubt any guest would be broken
> > > > if A20 line written through I/O port 92 couldn't be read via i8042.
> > > > The reverse (write using i8042 and read port 92) will work.
> > > >
> > >
> > > Why take the risk?
> >
> > The alternative is to route a signal from port 92 to i8042. Or maybe
> > port 92 should belong to i8042, that could make things simpler but
> > then the port would appear on non-PC architectures as well.
> >
> > But I doubt any OS would depend on such details, because the details
> > seem to be murky:
> > http://www.win.tue.nl/~aeb/linux/kbd/A20.html
>
>
> True, but I don't see why we should introduce a possible regression.
> I would at the very least test it on real hardware before doing the
> change.
I found one description on how i8042 and port 92 A20 lines work
together, chapter 6.11 in
http://www.smsc.com/media/Downloads_Public/Data_Sheets/47s45x.pdf
In that chip, the signals are OR'ed together. As I explained in my
reply to Jamie, QEMU does not implement this.
So I think the correct way is to move the port 92 to pckbd.c and maybe
add OR'ing (worth a separate patch).
prev parent reply other threads:[~2010-05-17 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 9:49 [Qemu-devel] [PATCH 0/2] pckbd improvements Blue Swirl
2010-05-16 9:42 ` [Qemu-devel] " Paolo Bonzini
2010-05-16 10:28 ` Blue Swirl
2010-05-16 17:57 ` Jamie Lokier
2010-05-16 20:06 ` Blue Swirl
2010-05-17 20:02 ` [Qemu-devel] A20 line control (was Re: [PATCH 0/2] pckbd improvements) Jamie Lokier
2010-05-17 11:16 ` [Qemu-devel] Re: [PATCH 0/2] pckbd improvements Paolo Bonzini
2010-05-17 16:34 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikyt3ktLW7t3LV3kpzuQfdCVREytquIFfOrHnV7@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).