From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33678 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P2JJE-0001dj-14
	for qemu-devel@nongnu.org; Sun, 03 Oct 2010 03:48:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P2JJB-0000Ly-FA
	for qemu-devel@nongnu.org; Sun, 03 Oct 2010 03:48:35 -0400
Received: from mail-qy0-f173.google.com ([209.85.216.173]:62108)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P2JJB-0000Lq-6j
	for qemu-devel@nongnu.org; Sun, 03 Oct 2010 03:48:33 -0400
Received: by qyk34 with SMTP id 34so1526379qyk.4
	for <qemu-devel@nongnu.org>; Sun, 03 Oct 2010 00:48:32 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1285267652-24454-1-git-send-email-weil@mail.berlios.de>
References: <1285267652-24454-1-git-send-email-weil@mail.berlios.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sun, 3 Oct 2010 07:48:12 +0000
Message-ID: <AANLkTikzV59oPS_-jonqJtdouAFn3TOoq4a+2USx_yXt@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] blockdev: Use GCC_FMT_ATTR (format
	checking)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Kevin Wolf <kwolf@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

Thanks, applied.

On Thu, Sep 23, 2010 at 6:47 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Additional changes:
>
> * Removed 'extern' from drive_add (avoids too long line).
> * Removed 'extern' from other functions (makes declarations
> =C2=A0consistent with others in same header file).
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> =C2=A0blockdev.h | =C2=A0 15 +++++++--------
> =C2=A01 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/blockdev.h b/blockdev.h
> index 89dcd9a..653affc 100644
> --- a/blockdev.h
> +++ b/blockdev.h
> @@ -34,14 +34,13 @@ struct DriveInfo {
> =C2=A0#define MAX_IDE_DEVS =C2=A0 2
> =C2=A0#define MAX_SCSI_DEVS =C2=A07
>
> -extern DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit);
> -extern int drive_get_max_bus(BlockInterfaceType type);
> -extern void drive_uninit(DriveInfo *dinfo);
> -extern DriveInfo *drive_get_by_blockdev(BlockDriverState *bs);
> -
> -extern QemuOpts *drive_add(const char *file, const char *fmt, ...);
> -extern DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi,
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 int *fatal_error);
> +DriveInfo *drive_get(BlockInterfaceType type, int bus, int unit);
> +int drive_get_max_bus(BlockInterfaceType type);
> +void drive_uninit(DriveInfo *dinfo);
> +DriveInfo *drive_get_by_blockdev(BlockDriverState *bs);
> +
> +QemuOpts *drive_add(const char *file, const char *fmt, ...) GCC_FMT_ATTR=
(2, 3);
> +DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi, int *fatal_err=
or);
>
> =C2=A0/* device-hotplug */
>
> --
> 1.7.1
>
>