From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44299 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJsxY-00033E-P8 for qemu-devel@nongnu.org; Wed, 02 Jun 2010 14:46:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJswe-0001vD-7P for qemu-devel@nongnu.org; Wed, 02 Jun 2010 14:45:41 -0400 Received: from mail-fx0-f45.google.com ([209.85.161.45]:54727) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJswd-0001uu-WA for qemu-devel@nongnu.org; Wed, 02 Jun 2010 14:45:40 -0400 Received: by fxm17 with SMTP id 17so5109699fxm.4 for ; Wed, 02 Jun 2010 11:45:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20100601200434.5908.19495.stgit@skyserv> <20100601201242.5908.21696.stgit@skyserv> Date: Wed, 2 Jun 2010 22:45:38 +0400 Message-ID: Subject: Re: [Qemu-devel] [PATCH 5/8] sparc64: use symbolic name for MMU index From: Igor Kovalenko Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On Wed, Jun 2, 2010 at 8:16 PM, Blue Swirl wrote: > On Tue, Jun 1, 2010 at 8:12 PM, Igor V. Kovalenko > wrote: >> From: Igor V. Kovalenko >> >> Signed-off-by: Igor V. Kovalenko >> --- >> =A0target-sparc/op_helper.c | =A0 28 ++++++++++++++++------------ >> =A01 files changed, 16 insertions(+), 12 deletions(-) >> >> diff --git a/target-sparc/op_helper.c b/target-sparc/op_helper.c >> index f5e153d..b9af52b 100644 >> --- a/target-sparc/op_helper.c >> +++ b/target-sparc/op_helper.c >> @@ -3322,18 +3322,19 @@ void helper_stdf(target_ulong addr, int mem_idx) >> =A0 =A0 helper_check_align(addr, 7); >> =A0#if !defined(CONFIG_USER_ONLY) >> =A0 =A0 switch (mem_idx) { >> - =A0 =A0case 0: >> + =A0 =A0case MMU_USER_IDX: >> =A0 =A0 =A0 =A0 stfq_user(addr, DT0); >> =A0 =A0 =A0 =A0 break; >> - =A0 =A0case 1: >> + =A0 =A0case MMU_KERNEL_IDX: >> =A0 =A0 =A0 =A0 stfq_kernel(addr, DT0); >> =A0 =A0 =A0 =A0 break; >> =A0#ifdef TARGET_SPARC64 >> - =A0 =A0case 2: >> + =A0 =A0case MMU_HYPV_IDX: >> =A0 =A0 =A0 =A0 stfq_hypv(addr, DT0); >> =A0 =A0 =A0 =A0 break; >> =A0#endif >> =A0 =A0 default: >> + =A0 =A0 =A0 =A0printf("helper_stdf: need to check MMU idx %d\n", mem_i= dx); > > Are these going to be useful or just leftover debugging? > >> =A0 =A0 =A0 =A0 break; >> =A0 =A0 } >> =A0#else >> @@ -3346,18 +3347,19 @@ void helper_lddf(target_ulong addr, int mem_idx) >> =A0 =A0 helper_check_align(addr, 7); >> =A0#if !defined(CONFIG_USER_ONLY) >> =A0 =A0 switch (mem_idx) { >> - =A0 =A0case 0: >> + =A0 =A0case MMU_USER_IDX: >> =A0 =A0 =A0 =A0 DT0 =3D ldfq_user(addr); >> =A0 =A0 =A0 =A0 break; >> - =A0 =A0case 1: >> + =A0 =A0case MMU_KERNEL_IDX: >> =A0 =A0 =A0 =A0 DT0 =3D ldfq_kernel(addr); >> =A0 =A0 =A0 =A0 break; >> =A0#ifdef TARGET_SPARC64 >> - =A0 =A0case 2: >> + =A0 =A0case MMU_HYPV_IDX: >> =A0 =A0 =A0 =A0 DT0 =3D ldfq_hypv(addr); >> =A0 =A0 =A0 =A0 break; >> =A0#endif >> =A0 =A0 default: >> + =A0 =A0 =A0 =A0printf("helper_stdf: need to check MMU idx %d\n", mem_i= dx); > > The function name is not correct for this and other cases below. > >> =A0 =A0 =A0 =A0 break; >> =A0 =A0 } >> =A0#else >> @@ -3373,24 +3375,25 @@ void helper_ldqf(target_ulong addr, int mem_idx) >> =A0 =A0 helper_check_align(addr, 7); >> =A0#if !defined(CONFIG_USER_ONLY) >> =A0 =A0 switch (mem_idx) { >> - =A0 =A0case 0: >> + =A0 =A0case MMU_USER_IDX: >> =A0 =A0 =A0 =A0 u.ll.upper =3D ldq_user(addr); >> =A0 =A0 =A0 =A0 u.ll.lower =3D ldq_user(addr + 8); >> =A0 =A0 =A0 =A0 QT0 =3D u.q; >> =A0 =A0 =A0 =A0 break; >> - =A0 =A0case 1: >> + =A0 =A0case MMU_KERNEL_IDX: >> =A0 =A0 =A0 =A0 u.ll.upper =3D ldq_kernel(addr); >> =A0 =A0 =A0 =A0 u.ll.lower =3D ldq_kernel(addr + 8); >> =A0 =A0 =A0 =A0 QT0 =3D u.q; >> =A0 =A0 =A0 =A0 break; >> =A0#ifdef TARGET_SPARC64 >> - =A0 =A0case 2: >> + =A0 =A0case MMU_HYPV_IDX: >> =A0 =A0 =A0 =A0 u.ll.upper =3D ldq_hypv(addr); >> =A0 =A0 =A0 =A0 u.ll.lower =3D ldq_hypv(addr + 8); >> =A0 =A0 =A0 =A0 QT0 =3D u.q; >> =A0 =A0 =A0 =A0 break; >> =A0#endif >> =A0 =A0 default: >> + =A0 =A0 =A0 =A0printf("helper_stdf: need to check MMU idx %d\n", mem_i= dx); >> =A0 =A0 =A0 =A0 break; >> =A0 =A0 } >> =A0#else >> @@ -3408,24 +3411,25 @@ void helper_stqf(target_ulong addr, int mem_idx) >> =A0 =A0 helper_check_align(addr, 7); >> =A0#if !defined(CONFIG_USER_ONLY) >> =A0 =A0 switch (mem_idx) { >> - =A0 =A0case 0: >> + =A0 =A0case MMU_USER_IDX: >> =A0 =A0 =A0 =A0 u.q =3D QT0; >> =A0 =A0 =A0 =A0 stq_user(addr, u.ll.upper); >> =A0 =A0 =A0 =A0 stq_user(addr + 8, u.ll.lower); >> =A0 =A0 =A0 =A0 break; >> - =A0 =A0case 1: >> + =A0 =A0case MMU_KERNEL_IDX: >> =A0 =A0 =A0 =A0 u.q =3D QT0; >> =A0 =A0 =A0 =A0 stq_kernel(addr, u.ll.upper); >> =A0 =A0 =A0 =A0 stq_kernel(addr + 8, u.ll.lower); >> =A0 =A0 =A0 =A0 break; >> =A0#ifdef TARGET_SPARC64 >> - =A0 =A0case 2: >> + =A0 =A0case MMU_HYPV_IDX: >> =A0 =A0 =A0 =A0 u.q =3D QT0; >> =A0 =A0 =A0 =A0 stq_hypv(addr, u.ll.upper); >> =A0 =A0 =A0 =A0 stq_hypv(addr + 8, u.ll.lower); >> =A0 =A0 =A0 =A0 break; >> =A0#endif >> =A0 =A0 default: >> + =A0 =A0 =A0 =A0printf("helper_stdf: need to check MMU idx %d\n", mem_i= dx); >> =A0 =A0 =A0 =A0 break; >> =A0 =A0 } >> =A0#else I'll fix names, turn printf into DPRINTF_MMU and resend. --=20 Kind regards, Igor V. Kovalenko