From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45462 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OC1gs-0001H7-8l for qemu-devel@nongnu.org; Tue, 11 May 2010 22:28:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OC1gq-0006tK-Vn for qemu-devel@nongnu.org; Tue, 11 May 2010 22:28:54 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:62418) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OC1gq-0006tD-R2 for qemu-devel@nongnu.org; Tue, 11 May 2010 22:28:52 -0400 Received: by pvg12 with SMTP id 12so228945pvg.4 for ; Tue, 11 May 2010 19:28:51 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 12 May 2010 10:28:51 +0800 Message-ID: From: TeLeMan Content-Type: text/plain; charset=UTF-8 Subject: [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel cirrus_post_load() will be executed twice when loading vm states and then the wrong physical memory will be registered. This issue may lead to crash qemu. Signed-off-by: TeLeMan --- hw/cirrus_vga.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 9dfe76a..262ba9c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga = { .version_id = 2, .minimum_version_id = 2, .minimum_version_id_old = 2, - .post_load = cirrus_post_load, .fields = (VMStateField []) { VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState), VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0, -- SUN OF A BEACH