qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] sparc32 esp fix spurious interrupts in chip reset
@ 2010-05-30 22:35 Artyom Tarasenko
  2010-06-01 17:42 ` [Qemu-devel] " Blue Swirl
  0 siblings, 1 reply; 9+ messages in thread
From: Artyom Tarasenko @ 2010-05-30 22:35 UTC (permalink / raw)
  To: qemu-devel; +Cc: blauwirbel, Artyom Tarasenko

lower interrupt during chip reset. Otherwise the ESP_RSTAT register
may get out of sync with the IRQ line status. This effect became
visible after commit 65899fe3

Signed-off-by: Artyom Tarasenko <atar4qemu@gmail.com>
---
 hw/esp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/esp.c b/hw/esp.c
index 0a8cf6e..0532c67 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -423,6 +423,7 @@ static void esp_reset(DeviceState *d)
 {
     ESPState *s = container_of(d, ESPState, busdev.qdev);
 
+    esp_lower_irq(s);
     memset(s->rregs, 0, ESP_REGS);
     memset(s->wregs, 0, ESP_REGS);
     s->rregs[ESP_TCHI] = TCHI_FAS100A; // Indicate fas100a
-- 
1.6.2.5

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2010-06-10  8:15 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-30 22:35 [Qemu-devel] [PATCH] sparc32 esp fix spurious interrupts in chip reset Artyom Tarasenko
2010-06-01 17:42 ` [Qemu-devel] " Blue Swirl
2010-06-01 19:56   ` Artyom Tarasenko
2010-06-01 20:09     ` Blue Swirl
2010-06-01 20:16       ` Artyom Tarasenko
2010-06-04 19:13         ` Blue Swirl
2010-06-04 20:30           ` Artyom Tarasenko
2010-06-09 20:35             ` Blue Swirl
2010-06-10  8:15               ` Artyom Tarasenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).