From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OBR3P-0004iw-Up
	for qemu-devel@nongnu.org; Mon, 10 May 2010 07:21:44 -0400
Received: from [140.186.70.92] (port=50345 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OBR3K-0004fg-GX
	for qemu-devel@nongnu.org; Mon, 10 May 2010 07:21:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <zltjiangshi@gmail.com>) id 1OBR3E-00058l-TE
	for qemu-devel@nongnu.org; Mon, 10 May 2010 07:21:38 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:42124)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <zltjiangshi@gmail.com>) id 1OBR3E-00058c-Q0
	for qemu-devel@nongnu.org; Mon, 10 May 2010 07:21:32 -0400
Received: by vws5 with SMTP id 5so252438vws.4
	for <qemu-devel@nongnu.org>; Mon, 10 May 2010 04:21:31 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4BE68342.2020202@mail.berlios.de>
References: <w2q69475c4c1005081900ya3a82946le9a5c88c1eec1fbb@mail.gmail.com>
	<4BE68342.2020202@mail.berlios.de>
Date: Mon, 10 May 2010 19:21:31 +0800
Message-ID: <AANLkTim0ICUCKawRlPgWGH_57udqWxVnd9Gd8KNci9--@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito
	north bridge used by fulong mini pc
From: chen huacai <zltjiangshi@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

>> --- a/hw/mips.h
>> +++ b/hw/mips.h
>> @@ -5,6 +5,9 @@
>> =A0/* gt64xxx.c */
>> =A0PCIBus *pci_gt64120_init(qemu_irq *pic);
>>
>> +/* bonito.c */
>> +PCIBus *bonito_init_2e(qemu_irq pic);
>> +
>> =A0/* ds1225y.c */
>> =A0void *ds1225y_init(target_phys_addr_t mem_base, const char *filename)=
;
>> =A0void ds1225y_set_protection(void *opaque, int protection);
>> -----
>>
>
> Please see my annotations above.
>
> Kind regards,
> Stefan Weil
>

Hi, Stefan, do you means that I should do something like this?

#ifdef CONFIG_FULONG
/* bonito.c */
PCIBus *bonito_init_2e(qemu_irq pic);
#endif

I found that even if I put CONFIG_FULONG=3Dy in
default-configs/mips64el-softmmu.mak, CONFIG_FULONG will not get
defined in config-target.h.
Because CONFIG_FULONG=3Dy will appear config-device.mak, but not
config-target.mak.
Could you please give me some suggestions?
--=20
Huacai Chen