From: Blue Swirl <blauwirbel@gmail.com>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc
Date: Sat, 22 May 2010 09:30:00 +0000 [thread overview]
Message-ID: <AANLkTim115vliJvcA3a7NJp5crDr7a_ZkYCDQH_BmGdy@mail.gmail.com> (raw)
In-Reply-To: <AANLkTilXcuHaJdf7CZJJRYzCPiOp1CIMUv5w01FUQJbA@mail.gmail.com>
Thanks, applied.
On Wed, May 12, 2010 at 2:28 AM, TeLeMan <geleman@gmail.com> wrote:
> cirrus_post_load() will be executed twice when loading vm states and then the
> wrong physical memory will be registered. This issue may lead to crash qemu.
>
> Signed-off-by: TeLeMan <geleman@gmail.com>
> ---
> hw/cirrus_vga.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
> index 9dfe76a..262ba9c 100644
> --- a/hw/cirrus_vga.c
> +++ b/hw/cirrus_vga.c
> @@ -3017,7 +3017,6 @@ static const VMStateDescription vmstate_pci_cirrus_vga
> = {
> .version_id = 2,
> .minimum_version_id = 2,
> .minimum_version_id_old = 2,
> - .post_load = cirrus_post_load,
> .fields = (VMStateField []) {
> VMSTATE_PCI_DEVICE(dev, PCICirrusVGAState),
> VMSTATE_STRUCT(cirrus_vga, PCICirrusVGAState, 0,
> --
> SUN OF A BEACH
>
>
prev parent reply other threads:[~2010-05-22 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 2:28 [Qemu-devel] [PATCH][RESEND] vmstate: fix breakage by 7e72abc382b700a72549e8147bdea413534eeedc TeLeMan
2010-05-12 23:05 ` [Qemu-devel] " Juan Quintela
2010-05-22 9:30 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim115vliJvcA3a7NJp5crDr7a_ZkYCDQH_BmGdy@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=geleman@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).