From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=60777 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PgLMq-0000Y2-11
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 13:05:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PgLMo-0005sq-0F
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 13:05:47 -0500
Received: from mail-ew0-f45.google.com ([209.85.215.45]:50773)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PgLMn-0005sm-Qs
	for qemu-devel@nongnu.org; Fri, 21 Jan 2011 13:05:45 -0500
Received: by ewy10 with SMTP id 10so1123128ewy.4
	for <qemu-devel@nongnu.org>; Fri, 21 Jan 2011 10:05:45 -0800 (PST)
MIME-Version: 1.0
Date: Fri, 21 Jan 2011 18:05:41 +0000
Message-ID: <AANLkTim1mabTM2mxSQP86bTPL+Ny2QeiydR-upg0qEf1@mail.gmail.com>
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] checkpatch.pl false positives with HELPER macro
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>

If you run checkpatch on the patch at
http://patchwork.ozlabs.org/patch/79735/

then it has a number of false-positive errors like this:

ERROR: need consistent spacing around '*' (ctx:WxV)
#74: FILE: target-arm/neon_helper.c:201:
+uint32_t HELPER(neon_qadd_u32)(CPUState *env, uint32_t a, uint32_t b)
                                         ^
which I assume are because it's got confused by the HELPER() macro.
Maybe HELPER() is sufficiently commonly used to be worth teaching it
about as a special case?

Also, checkpatch says:

sataddsub.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

but there isn't anything about CHECKPATCH in our MAINTAINERS file...

-- PMM