* [Qemu-devel] checkpatch.pl false positives with HELPER macro
@ 2011-01-21 18:05 Peter Maydell
2011-01-21 18:19 ` [Qemu-devel] " Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-01-21 18:05 UTC (permalink / raw)
To: QEMU Developers; +Cc: Blue Swirl
If you run checkpatch on the patch at
http://patchwork.ozlabs.org/patch/79735/
then it has a number of false-positive errors like this:
ERROR: need consistent spacing around '*' (ctx:WxV)
#74: FILE: target-arm/neon_helper.c:201:
+uint32_t HELPER(neon_qadd_u32)(CPUState *env, uint32_t a, uint32_t b)
^
which I assume are because it's got confused by the HELPER() macro.
Maybe HELPER() is sufficiently commonly used to be worth teaching it
about as a special case?
Also, checkpatch says:
sataddsub.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
but there isn't anything about CHECKPATCH in our MAINTAINERS file...
-- PMM
^ permalink raw reply [flat|nested] 2+ messages in thread* [Qemu-devel] Re: checkpatch.pl false positives with HELPER macro
2011-01-21 18:05 [Qemu-devel] checkpatch.pl false positives with HELPER macro Peter Maydell
@ 2011-01-21 18:19 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2011-01-21 18:19 UTC (permalink / raw)
To: Peter Maydell; +Cc: QEMU Developers
On Fri, Jan 21, 2011 at 6:05 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> If you run checkpatch on the patch at
> http://patchwork.ozlabs.org/patch/79735/
>
> then it has a number of false-positive errors like this:
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #74: FILE: target-arm/neon_helper.c:201:
> +uint32_t HELPER(neon_qadd_u32)(CPUState *env, uint32_t a, uint32_t b)
> ^
> which I assume are because it's got confused by the HELPER() macro.
> Maybe HELPER() is sufficiently commonly used to be worth teaching it
> about as a special case?
There's also glue() and other macro wizardry. I don't think that can be avoided.
> Also, checkpatch says:
>
> sataddsub.patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> but there isn't anything about CHECKPATCH in our MAINTAINERS file...
I wouldn't be very optimistic about the rate of false positives, so
perhaps this suggestion should be turned into a warning about them.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-21 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-21 18:05 [Qemu-devel] checkpatch.pl false positives with HELPER macro Peter Maydell
2011-01-21 18:19 ` [Qemu-devel] " Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).