From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43980 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PuPb7-0002og-JG
	for qemu-devel@nongnu.org; Tue, 01 Mar 2011 08:26:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <corentin.chary@gmail.com>) id 1PuPb6-0006YS-6b
	for qemu-devel@nongnu.org; Tue, 01 Mar 2011 08:26:41 -0500
Received: from mail-ew0-f45.google.com ([209.85.215.45]:49032)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <corentin.chary@gmail.com>) id 1PuPb6-0006Xr-2J
	for qemu-devel@nongnu.org; Tue, 01 Mar 2011 08:26:40 -0500
Received: by ewy24 with SMTP id 24so1774269ewy.4
	for <qemu-devel@nongnu.org>; Tue, 01 Mar 2011 05:26:33 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <4D6C506C.2070405@cn.fujitsu.com>
References: <4D674B83.9030902@cn.fujitsu.com>
	<AANLkTi=d4Oz6np69RVWNyyQau7NFECAFtaY-zHcYDDVP@mail.gmail.com>
	<4D6C506C.2070405@cn.fujitsu.com>
Date: Tue, 1 Mar 2011 13:26:31 +0000
Message-ID: <AANLkTim44Yf2_1ScJ51bgY92dcm2gGNpgdcRnLW0wt49@mail.gmail.com>
From: Corentin Chary <corentin.chary@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH v2] fix vnc regression
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On Tue, Mar 1, 2011 at 1:48 AM, Wen Congyang <wency@cn.fujitsu.com> wrote:
> This patch fix the following two regressions:
> 1. we should use bitmap_set() and bitmap_clear() to replace vnc_set_bits(=
).
> 2. The unit of bitmap_intersects()'third parameter is bit, not words.
> =C2=A0 But we pass the num of words to bitmap_intersects().
>
> Changes from v1 to v2:
> 1. fix the third argument of bitmap_clear()
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>

Seems ok, tested with valgrind this time.

But could you re-send this one and the other one at
http://patchwork.ozlabs.org/patch/84887/ :
- with appropriate Signed-off-by: and changelog for the other patch
- using a const size_t width =3D ds_get_width(vs->ds) / 16; in both
patchs to make the call more explicit

Thanks,
--=20
Corentin Chary
http://xf.iksaif.net