[Qemu-devel] don't look for libuuid on Darwin

[Qemu-devel] don't look for libuuid on Darwin

[C.W. Betts]

In Darwin, the libSystem.B.dylib is a container for a lot of  
libraries, among them is libuuid.  However, there isn't, by default, a  
static link  libuuid to libSystem.  The configure script should just  
check to see if there's a uuid header and don't look for a libuuid.

Re: [Qemu-devel] don't look for libuuid on Darwin

[Christoph Hellwig]

On Sun, Nov 08, 2009 at 06:37:34PM -0700, C.W. Betts wrote:
> In Darwin, the libSystem.B.dylib is a container for a lot of  
> libraries, among them is libuuid.  However, there isn't, by default, a  
> static link  libuuid to libSystem.  The configure script should just  
> check to see if there's a uuid header and don't look for a libuuid.

Checking for static libraries is a bad idea in general.  Care to submit
a patch to fix this check up to do the usual compile test (tiny code
fragment that needs libuuid)

Re: [Qemu-devel] don't look for libuuid on Darwin

[C.W. Betts]

On Nov 9, 2009, at 12:22 PM, Christoph Hellwig wrote:

> On Mon, Nov 09, 2009 at 11:46:13AM -0700, C.W. Betts wrote:
>> Does this work?
>>
>> diff --git a/configure b/configure
>> index aa2cc43..00e04e9 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1060,7 +1060,11 @@ fi
>> ##########################################
>> # uuid_generate() probe, used for vdi block driver
>> if test "$uuid" != "no" ; then
>> -  uuid_libs="-luuid"
>> +  if test "$darwin" == "yes"; then
>> +    uuid_libs=""
>> +  else
>> +    uuid_libs="-luuid"
>> +  fi
>
> It might work, but does Darwin really provide no libuuid at all?  I
> thought it was just the static one that is missing?
The uuid definitions are in the libSystem library, which everything  
links against.  LibSystem also includes libc, libm, pthreads, etc.
>
> If it really is the case a comment above the test would help.
>
> Also I think you should try to keep the mailinglist on Cc - it  
> includes
> people that can provide valueable feedback, and also people that  
> unlike
> me can actually apply the patch to the qemu repository.
heh, sorry. I replied to the wrong message.
>
>

[Qemu-devel] [PATCH] sheepdog: fix compile error on systems without TCP_CORK

[MORITA Kazutaka]

WIN32 is not only the system which doesn't have TCP_CORK (e.g. OS X).

Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
---

Betts, I think this patch fix the compile error.  Can you try this
one?

 block/sheepdog.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/sheepdog.c b/block/sheepdog.c
index 69a2494..81aa564 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -889,7 +889,7 @@ static int aio_flush_request(void *opaque)
     return !QLIST_EMPTY(&s->outstanding_aio_head);
 }
 
-#ifdef _WIN32
+#if !defined(SOL_TCP) || !defined(TCP_CORK)
 
 static int set_cork(int fd, int v)
 {
-- 
1.5.6.5

Re: [Qemu-devel] [PATCH] sheepdog: fix compile error on systems without TCP_CORK

[C.W. Betts]

It compiles now.
On Jul 7, 2010, at 12:25 AM, MORITA Kazutaka wrote:

> WIN32 is not only the system which doesn't have TCP_CORK (e.g. OS X).
> 
> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> ---
> 
> Betts, I think this patch fix the compile error.  Can you try this
> one?
> 
> block/sheepdog.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 69a2494..81aa564 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -889,7 +889,7 @@ static int aio_flush_request(void *opaque)
>     return !QLIST_EMPTY(&s->outstanding_aio_head);
> }
> 
> -#ifdef _WIN32
> +#if !defined(SOL_TCP) || !defined(TCP_CORK)
> 
> static int set_cork(int fd, int v)
> {
> -- 
> 1.5.6.5
> 
> 
> 

Re: [Qemu-devel] [PATCH] sheepdog: fix compile error on systems without TCP_CORK

[Blue Swirl]

Thanks, applied. It also fixes OpenBSD build.

On Wed, Jul 7, 2010 at 6:25 AM, MORITA Kazutaka
<morita.kazutaka@lab.ntt.co.jp> wrote:
> WIN32 is not only the system which doesn't have TCP_CORK (e.g. OS X).
>
> Signed-off-by: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
> ---
>
> Betts, I think this patch fix the compile error.  Can you try this
> one?
>
>  block/sheepdog.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 69a2494..81aa564 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -889,7 +889,7 @@ static int aio_flush_request(void *opaque)
>     return !QLIST_EMPTY(&s->outstanding_aio_head);
>  }
>
> -#ifdef _WIN32
> +#if !defined(SOL_TCP) || !defined(TCP_CORK)
>
>  static int set_cork(int fd, int v)
>  {
> --
> 1.5.6.5
>
>
>