From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=50169 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PgZMt-0003eh-Jn for qemu-devel@nongnu.org; Sat, 22 Jan 2011 04:02:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PgZMs-0005Ok-RP for qemu-devel@nongnu.org; Sat, 22 Jan 2011 04:02:47 -0500 Received: from mail-fx0-f45.google.com ([209.85.161.45]:65088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PgZMs-0005Og-Ie for qemu-devel@nongnu.org; Sat, 22 Jan 2011 04:02:46 -0500 Received: by fxm12 with SMTP id 12so2685019fxm.4 for ; Sat, 22 Jan 2011 01:02:45 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4D386C26.5070007@mail.berlios.de> References: <1295474688-6219-1-git-send-email-ctang@us.ibm.com> <20110120130140.GA8143@lst.de> <4D386C26.5070007@mail.berlios.de> Date: Sat, 22 Jan 2011 09:02:45 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/5] Fast Virtual Disk (FVD) Proposal Part 1 From: Peter Maydell Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Chunqiang Tang , Christoph Hellwig , qemu-devel@nongnu.org On 20 January 2011 17:08, Stefan Weil wrote: > Yes, that's a problem with some parts of the old code. > For files which you want to modify, you could remove > the spaces with your script before applying your other > modifications and create a separate patch which only > removes the superfluous spaces. (This kind of came up in the other thread about fixing non-C89 comments. I don't have any particular interest in this area of the qemu source so this is a general remark.) I definitely dislike patches which change whitespace or indentation for an entire file, even if they are standalone "only fixing whitespace" patches; they make it much harder to deal with forks and branches of qemu. I would prefer it if we only fix whitespace, indent and bracing for lines we're touching anyway. -- PMM