From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59153 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PyseG-00086p-J9
	for qemu-devel@nongnu.org; Sun, 13 Mar 2011 17:16:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <c.m.brunner@gmail.com>) id 1PyseF-0000C0-8z
	for qemu-devel@nongnu.org; Sun, 13 Mar 2011 17:16:24 -0400
Received: from mail-iy0-f173.google.com ([209.85.210.173]:52153)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <c.m.brunner@gmail.com>) id 1PyseF-0000Bu-5w
	for qemu-devel@nongnu.org; Sun, 13 Mar 2011 17:16:23 -0400
Received: by iym7 with SMTP id 7so5110699iym.4
	for <qemu-devel@nongnu.org>; Sun, 13 Mar 2011 14:16:21 -0700 (PDT)
MIME-Version: 1.0
Sender: c.m.brunner@gmail.com
In-Reply-To: <1299478669-11231-1-git-send-email-aurelien@aurel32.net>
References: <1299478669-11231-1-git-send-email-aurelien@aurel32.net>
Date: Sun, 13 Mar 2011 22:16:21 +0100
Message-ID: <AANLkTim5J0pyXSj0T6-A8ryL_+gFd87mdTj+6SDAYzex@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] rbd: don't link with -lcrypto
From: Christian Brunner <chb@muc.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Reply-To: chb@muc.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

You are right, libcrypto can be omitted.

(Recent versions of ceph use crypto++ anyway.)

Thanks, Christian


Reviewed-by: Christian Brunner <chb@muc.de>


2011/3/7 Aurelien Jarno <aurelien@aurel32.net>:
> rbd support tries to both link with -lrados and -lcrypto. While the
> first one is of course necessary, the second is not necessary (only
> librados ifself needs to link with libcrypto).
>
> This fixes a licensing issue: qemu as a whole is GPL v2, and thus can't
> be linked with OpenSSL without an exception in the license, which seems
> difficult to get given the number of persons involved.
>
> Cc: Christian Brunner <chb@muc.de>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> =A0configure | =A0 =A02 +-
> =A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index ef51a58..5932e39 100755
> --- a/configure
> +++ b/configure
> @@ -1801,7 +1801,7 @@ if test "$rbd" !=3D "no" ; then
> =A0#include <rados/librados.h>
> =A0int main(void) { rados_initialize(0, NULL); return 0; }
> =A0EOF
> - =A0rbd_libs=3D"-lrados -lcrypto"
> + =A0rbd_libs=3D"-lrados"
> =A0 if compile_prog "" "$rbd_libs" ; then
> =A0 =A0 librados_too_old=3Dno
> =A0 =A0 cat > $TMPC <<EOF
> --
> 1.7.2.3
>
>
>