From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: mjt@tls.msk.ru, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 3/4] ide: Ignore double DMA transfer starts/stops
Date: Fri, 26 Nov 2010 16:43:47 +0000 [thread overview]
Message-ID: <AANLkTimADHz89qKBq2BBSjLeEB4Eai0Oz=CQMjQuHZdj@mail.gmail.com> (raw)
In-Reply-To: <1290788492-17703-4-git-send-email-kwolf@redhat.com>
On Fri, Nov 26, 2010 at 4:21 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> You can only start a DMA transfer if it's not running yet, and you can only
> cancel it if it's running.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/ide/pci.c | 60 ++++++++++++++++++++++++++++++---------------------------
> 1 files changed, 32 insertions(+), 28 deletions(-)
The PIIX4 spec isn't clear on the behavior but you seem to have worked
out that this makes FreeBSD happier. Would be nice to hear from
someone who knows PIIX4 IDE well.
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2010-11-26 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 16:21 [Qemu-devel] [PATCH 0/4] ide: Some DMA related fixes Kevin Wolf
2010-11-26 16:21 ` [Qemu-devel] [PATCH 1/4] ide: Factor ide_dma_set_inactive out Kevin Wolf
2010-11-26 16:38 ` [Qemu-devel] " Stefan Hajnoczi
2010-11-26 16:21 ` [Qemu-devel] [PATCH 2/4] ide: Set bus master inactive on error Kevin Wolf
2010-11-26 16:40 ` [Qemu-devel] " Stefan Hajnoczi
2010-11-26 16:21 ` [Qemu-devel] [PATCH 3/4] ide: Ignore double DMA transfer starts/stops Kevin Wolf
2010-11-26 16:43 ` Stefan Hajnoczi [this message]
2010-11-26 16:21 ` [Qemu-devel] [PATCH 4/4] ide: Reset current_addr after stopping DMA Kevin Wolf
2010-11-26 16:45 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimADHz89qKBq2BBSjLeEB4Eai0Oz=CQMjQuHZdj@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).