From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45172 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PnFfT-0008M6-Uu
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 14:25:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PnFfS-0006Ee-8S
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 14:25:35 -0500
Received: from mail-ey0-f173.google.com ([209.85.215.173]:54444)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peter.maydell@linaro.org>) id 1PnFfS-0006EQ-4A
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 14:25:34 -0500
Received: by eyg7 with SMTP id 7so359061eyg.4
	for <qemu-devel@nongnu.org>; Wed, 09 Feb 2011 11:25:33 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20110209184011.GB3131@volta.aurel32.net>
References: <1297268850-5777-1-git-send-email-peter.maydell@linaro.org>
	<1297268850-5777-2-git-send-email-peter.maydell@linaro.org>
	<20110209184011.GB3131@volta.aurel32.net>
Date: Wed, 9 Feb 2011 19:25:32 +0000
Message-ID: <AANLkTimAikSSoj8Xoj02HBA0mAnHBJRREPLTgFb84nJr@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/6] softfloat: Add float16 type and
	float16 NaN handling functions
From: Peter Maydell <peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Christophe Lyon <christophe.lyon@st.com>, qemu-devel@nongnu.org, patches@linaro.org

On 9 February 2011 18:40, Aurelien Jarno <aurelien@aurel32.net> wrote:
> You should also add it in the USE_SOFTFLOAT_STRUCT_TYPES case, so that
> we can check the type correctness. Last time I tried, it was not
> compiling in this mode

Yeah, it doesn't compile, but it's not too hard to fix (at least for ARM
targets). It looks like we need a new macro:
#ifdef USE_SOFTFLOAT_STRUCT_TYPES
#define const_float32(x) { x }
#else
#define const_float32(x) x
#endif

so you can define arrays of float32 etc:
static const float32 my_array[] = {
    const_float32(0x00000000),				/* single 0.0 */
    const_float32(0x3f800000),				/* single 1.0 */
 };

as there are a couple of places that do this and complain otherwise.

...unless anybody can come up with a cleverer fix.

-- PMM