From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49976 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OdRZe-0006Tz-TP for qemu-devel@nongnu.org; Mon, 26 Jul 2010 13:34:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OdRTI-0006zc-7l for qemu-devel@nongnu.org; Mon, 26 Jul 2010 13:28:13 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:39800) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OdRTI-0006zJ-5C for qemu-devel@nongnu.org; Mon, 26 Jul 2010 13:28:12 -0400 Received: by vws19 with SMTP id 19so2658273vws.4 for ; Mon, 26 Jul 2010 10:28:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1280152877-29037-5-git-send-email-kwolf@redhat.com> References: <1280152877-29037-1-git-send-email-kwolf@redhat.com> <1280152877-29037-5-git-send-email-kwolf@redhat.com> Date: Mon, 26 Jul 2010 12:28:08 -0500 Message-ID: From: Anthony Liguori Content-Type: multipart/alternative; boundary=005045016bc848d17c048c4db505 Subject: [Qemu-devel] Re: [PATCH 4/7] move 'unsafe' to end of caching modes in help List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org --005045016bc848d17c048c4db505 Content-Type: text/plain; charset=ISO-8859-1 Hi Kevin, There's an on-going discussion on this patch. Could you drop it from your pull request but leave it in your tree until the discussion is resolved? Thanks, Anthony Liguori On Jul 26, 2010 9:01 AM, "Kevin Wolf" wrote: From: Bruce Rogers Libvirt parses qemu help output to determine qemu features. In particular it probes for the following: "cache=writethrough|writeback|none". The addition of the unsafe cache mode was inserted within this string, as opposed to being added to the end, which impacted libvirt's probe. Unbreak libvirt by keeping the existing cache modes intact and add unsafe to the end. This problem only manifests itself if a caching mode is explicitly specified in the libvirt xml, in which case older syntax for caching is passed to qemu, which it no longer understands. Signed-off-by: Bruce Rogers Signed-off-by: Kevin Wolf --- qemu-options.hx | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 0d7dd90..9ecc54e 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -118,7 +118,7 @@ ETEXI DEF("drive", HAS_ARG, QEMU_OPTION_drive, "-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]\n" " [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]\n" - " [,cache=writethrough|writeback|unsafe|none][,format=f]\n" + " [,cache=writethrough|writeback|none|unsafe][,format=f]\n" " [,serial=s][,addr=A][,id=name][,aio=threads|native]\n" " [,readonly=on|off]\n" " use 'file' as a drive image\n", QEMU_ARCH_ALL) -- 1.7.1.1 --005045016bc848d17c048c4db505 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

Hi Kevin,

There's an on-going discussion on this patch.=A0 Could you drop it f= rom your pull request but leave it in your tree until the discussion is res= olved?

Thanks,

Anthony Liguori

On Jul 26, 2010 9:01 AM, "Kevin Wolf"= ; <kwolf@redhat.com> wrote:
From: Bruce Rogers <brogers@= novell.com>

Libvirt parses qemu help output to determine qemu features. In particular it probes for the following: "cache=3Dwritethrough|writeback|none"= ;. The
addition of the unsafe cache mode was inserted within this string, as
opposed to being added to the end, which impacted libvirt's probe.
Unbreak libvirt by keeping the existing cache modes intact and add
unsafe to the end.

This problem only manifests itself if a caching mode is explicitly
specified in the libvirt xml, in which case older syntax for caching is
passed to qemu, which it =A0no longer understands.

Signed-off-by: Bruce Rogers <broge= rs@novell.com>
Signed-off-by: Kevin Wolf <kwolf@red= hat.com>
---
=A0qemu-options.hx | =A0 =A02 +-
=A01 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 0d7dd90..9ecc54e 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -118,7 +118,7 @@ ETEXI
=A0DEF("drive", HAS_ARG, QEMU_OPTION_drive,
=A0 =A0 "-drive [file=3Dfile][,if=3Dtype][,bus=3Dn][,unit=3Dm][,media= =3Dd][,index=3Di]\n"
=A0 =A0 " =A0 =A0 =A0 [,cyls=3Dc,heads=3Dh,secs=3Ds[,trans=3Dt]][,sna= pshot=3Don|off]\n"
- =A0 =A0" =A0 =A0 =A0 [,cache=3Dwritethrough|writeback|unsafe|none][,= format=3Df]\n"
+ =A0 =A0" =A0 =A0 =A0 [,cache=3Dwritethrough|writeback|none|unsafe][,= format=3Df]\n"
=A0 =A0 " =A0 =A0 =A0 [,serial=3Ds][,addr=3DA][,id=3Dname][,aio=3Dthr= eads|native]\n"
=A0 =A0 " =A0 =A0 =A0 [,readonly=3Don|off]\n"
=A0 =A0 " =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0use 'file' as a driv= e image\n", QEMU_ARCH_ALL)
--
1.7.1.1

--005045016bc848d17c048c4db505--