qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH v2] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD
Date: Tue, 25 Jan 2011 16:25:04 +0000	[thread overview]
Message-ID: <AANLkTimEy7AGFd59oB+wesbLoSD6M+bE52Pe0a1D=6JB@mail.gmail.com> (raw)
In-Reply-To: <20110125145657.GD15666@redhat.com>

On Tue, Jan 25, 2011 at 2:56 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Tue, Jan 25, 2011 at 02:53:31PM +0000, Stefan Hajnoczi wrote:
>> It is not possible to use virtio-ioeventfd when building without an I/O
>> thread.  We rely on a signal to kick us out of vcpu execution.  Timers
>> and AIO use SIGALRM and SIGUSR2 respectively.  Unfortunately eventfd
>> does not support O_ASYNC (SIGIO) so eventfd cannot be used in a signal
>> driven manner.
>>
>> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
>> ---
>>  kvm-all.c |    8 ++++++--
>>  1 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/kvm-all.c b/kvm-all.c
>> index 255b6fa..881ea32 100644
>> --- a/kvm-all.c
>> +++ b/kvm-all.c
>> @@ -449,10 +449,14 @@ int kvm_check_extension(KVMState *s, unsigned int extension)
>>
>>  static int kvm_check_many_ioeventfds(void)
>>  {
>> -    /* Older kernels have a 6 device limit on the KVM io bus.  Find out so we
>> +    /* Userspace can use ioeventfd for virtqueue kick.  This requires a host
>
> virtqueue kick -> io notifications?

Fixed in v3.

Stefan

      reply	other threads:[~2011-01-25 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 14:53 [Qemu-devel] [PATCH v2] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD Stefan Hajnoczi
2011-01-25 14:56 ` [Qemu-devel] " Michael S. Tsirkin
2011-01-25 16:25   ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimEy7AGFd59oB+wesbLoSD6M+bE52Pe0a1D=6JB@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).