From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42522 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OUwxr-0002Jm-UF
	for qemu-devel@nongnu.org; Sat, 03 Jul 2010 03:16:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OUwxq-0004la-Ax
	for qemu-devel@nongnu.org; Sat, 03 Jul 2010 03:16:39 -0400
Received: from mail-pw0-f45.google.com ([209.85.160.45]:38428)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OUwxq-0004lO-1R
	for qemu-devel@nongnu.org; Sat, 03 Jul 2010 03:16:38 -0400
Received: by pwi2 with SMTP id 2so105480pwi.4
	for <qemu-devel@nongnu.org>; Sat, 03 Jul 2010 00:16:36 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4C2D86ED.4080108@jp.fujitsu.com>
References: <4C2C0C5D.8030905@jp.fujitsu.com>
	<AANLkTinYAzgTT8wBZLI06uwjw_bHq1rlzBRs0QFyRGvk@mail.gmail.com>
	<4C2D86ED.4080108@jp.fujitsu.com>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 3 Jul 2010 07:16:16 +0000
Message-ID: <AANLkTimHMSB-9SFm6NcuqUFYikS6rPoH19Fbj250Y2BY@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Makefile: add fsdev/*.{o,d} to clean
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: qemu-devel@nongnu.org

On Fri, Jul 2, 2010 at 6:27 AM, Hidetoshi Seto
<seto.hidetoshi@jp.fujitsu.com> wrote:
> (2010/07/02 4:48), Blue Swirl wrote:
>> 2010/7/1 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
>>> There were fsdev/qemu-fsdev.{o,d} not removed at "make clean".
>>>
>>> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
>>> ---
>>> =C2=A0Makefile | =C2=A0 =C2=A02 +-
>>> =C2=A01 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 560eac6..ce5f0e6 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -159,7 +159,7 @@ clean:
>>> =C2=A0# avoid old build problems by removing potentially incorrect old =
files
>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0rm -f config.mak op-i386.h opc-i386.h gen-op=
-i386.h op-arm.h opc-arm.h gen-op-arm.h
>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0rm -f *.o *.d *.a $(TOOLS) TAGS cscope.* *.p=
od *~ */*~
>>> - =C2=A0 =C2=A0 =C2=A0 rm -f slirp/*.o slirp/*.d audio/*.o audio/*.d bl=
ock/*.o block/*.d net/*.o net/*.d
>>> + =C2=A0 =C2=A0 =C2=A0 rm -f {slirp,audio,block,net,fsdev}/*.{o,d}
>>
>> Not every shell out there support {}:
>> dash -c 'echo {a,b}*.c'
>> {a,b}*.c
>>
>> bash -c 'echo {a,b}*.c'
>> acl.c aes.c aio.c alpha-dis.c arch_init.c arm-dis.c arm-semi.c async.c
>> balloon.c block-migration.c block.c blockdev.c bt-host.c bt-vhci.c
>> buffered_file.c
>
> You are right, but I found that Makefile already has:
>
> =C2=A0169 distclean: clean
> (snip)
> =C2=A0174 =C2=A0 =C2=A0 =C2=A0 =C2=A0 rm -f qemu-{doc,tech}.{info,aux,cp,=
dvi,fn,info,ky,log,pdf,pg,toc,tp,vr}
>
> So then is it better to rewrite this line not to use {} ...?

Yes, a patch for that would be nice.