From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58764 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q4yDx-0003yp-Js
	for qemu-devel@nongnu.org; Wed, 30 Mar 2011 12:26:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Q4yDv-00032d-Nk
	for qemu-devel@nongnu.org; Wed, 30 Mar 2011 12:26:25 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:58300)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Q4yDv-00032M-LU
	for qemu-devel@nongnu.org; Wed, 30 Mar 2011 12:26:23 -0400
Received: by gxk26 with SMTP id 26so671840gxk.4
	for <qemu-devel@nongnu.org>; Wed, 30 Mar 2011 09:26:22 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110330160953.GB26439@redhat.com>
References: <cover.1301346785.git.mst@redhat.com>
	<a9bae93a939257ae0c01d136aaebd9d488cff071.1301346785.git.mst@redhat.com>
	<AANLkTi=0o7HsKmLEOENdRcEO28nKFNHfm8JVQpz4QWNS@mail.gmail.com>
	<20110330160953.GB26439@redhat.com>
Date: Wed, 30 Mar 2011 17:26:22 +0100
Message-ID: <AANLkTimJUH4vCUjHnpqhcJqYQzmMsPSmJrNEpRDUQ7bQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] vhost: roll our own cpu map variant
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, gleb@redhat.com, Jes Sorensen <Jes.Sorensen@redhat.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, armbru@redhat.com, Christoph Hellwig <hch@infradead.org>, Alex Williamson <alex.williamson@redhat.com>, Amit Shah <amit.shah@redhat.com>

On Wed, Mar 30, 2011 at 5:09 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Tue, Mar 29, 2011 at 11:53:54AM +0100, Stefan Hajnoczi wrote:
>> On Mon, Mar 28, 2011 at 10:14 PM, Michael S. Tsirkin <mst@redhat.com> wr=
ote:
>> > vhost used cpu_physical_memory_map to get the
>> > virtual address for the ring, however,
>> > this will exit on an illegal RAM address.
>> > Since the addresses are guest-controlled, we
>> > shouldn't do that.
>> >
>> > Switch to our own variant that uses the vhost
>> > tables and returns an error instead of exiting.
>>
>> We should make all of QEMU more robust instead of just vhost. =A0Perhaps
>> introduce cpu_physical_memory_map_nofail(...) that aborts like the
>> current cpu_physical_memory_map() implementation and then make non-hw/
>> users call that one. =A0hw/ users should check for failure.
>>
>> Stefan
>
> Yea, well ... at least vhost-net wants to also check
> it is given a ram address, not some other physical address.
> We could generally replace the memory management in vhost-net
> by some other logic, when that's done this one can
> go away as well.

Sounds like you do not want to refactor physical memory access for
non-vhost.  Fair enough but we have to do it sooner or later in order
to make all of QEMU more robust.  If vhost-net is protected but the
IDE CD-ROM and virtio-blk disk still have issues then we haven't
reached our goal yet.  Any way I can convince you to do a generic API?
:)

Stefan