From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36503 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHgOe-0004Wd-D7 for qemu-devel@nongnu.org; Sun, 14 Nov 2010 12:29:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHg5i-0006Ve-HT for qemu-devel@nongnu.org; Sun, 14 Nov 2010 12:10:14 -0500 Received: from mail-qy0-f180.google.com ([209.85.216.180]:60179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHg5i-0006VU-FK for qemu-devel@nongnu.org; Sun, 14 Nov 2010 12:10:10 -0500 Received: by qyk36 with SMTP id 36so1316182qyk.4 for ; Sun, 14 Nov 2010 09:10:09 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20101104222132.GB30050@os.inf.tu-dresden.de> References: <20101104222132.GB30050@os.inf.tu-dresden.de> Date: Sun, 14 Nov 2010 17:10:09 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined instruction From: Peter Maydell Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Lackorzynski Cc: qemu-devel@nongnu.org On 4 November 2010 22:21, Adam Lackorzynski wrote: > > Refine check on bkpt so that smc and undefined instruction encodings are > handled as an undefined instruction and trap. > > Signed-off-by: Adam Lackorzynski This patch looks good to me. I note that there's actually an implementation of SMC and at least some of the TrustZone extension in the qemu-meego tree. However, for the moment this patch is correct: SMC should UNDEF on cores without TrustZone (which is what current qemu effectively is). Acked-by: Peter Maydell -- PMM