From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37930 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P4Vyk-0007kp-NS
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 05:44:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P4Vyh-0005wF-O9
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 05:44:32 -0400
Received: from mail-qy0-f180.google.com ([209.85.216.180]:48909)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <blauwirbel@gmail.com>) id 1P4Vyh-0005t3-KX
	for qemu-devel@nongnu.org; Sat, 09 Oct 2010 05:44:31 -0400
Received: by mail-qy0-f180.google.com with SMTP id 1so1787022qyk.4
	for <qemu-devel@nongnu.org>; Sat, 09 Oct 2010 02:44:31 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1286478958-11252-1-git-send-email-weil@mail.berlios.de>
References: <4CAE1A0D.7000704@redhat.com>
	<1286478958-11252-1-git-send-email-weil@mail.berlios.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Sat, 9 Oct 2010 09:44:11 +0000
Message-ID: <AANLkTimJrh9t-jSEDikUsdUSKK2yWJtko7nM3T4yYq3j@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] configure: Send error message from spice
	check to /dev/null
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

Thanks, applied.

On Thu, Oct 7, 2010 at 7:15 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> pkg-config is not always available (e.g. on win32 hosts),
> but we don't want to see the 'command not found' error message.
>
> Redirect stdout and stderr to /dev/null.
>
> v2:
>
> * Removed changes which should not have been here.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> =C2=A0configure | =C2=A0 =C2=A02 +-
> =C2=A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index e67d076..cc19d82 100755
> --- a/configure
> +++ b/configure
> @@ -2089,7 +2089,7 @@ int main(void) { spice_server_new(); return 0; }
> =C2=A0EOF
> =C2=A0 spice_cflags=3D$($pkgconfig --cflags spice-protocol spice-server 2=
>/dev/null)
> =C2=A0 spice_libs=3D$($pkgconfig --libs spice-protocol spice-server 2>/de=
v/null)
> - =C2=A0if $pkgconfig --atleast-version=3D0.5.3 spice-server &&\
> + =C2=A0if $pkgconfig --atleast-version=3D0.5.3 spice-server >/dev/null 2=
>&1 && \
> =C2=A0 =C2=A0 =C2=A0compile_prog "$spice_cflags" "$spice_libs" ; then
> =C2=A0 =C2=A0 spice=3D"yes"
> =C2=A0 =C2=A0 libs_softmmu=3D"$libs_softmmu $spice_libs"
> --
> 1.7.1
>
>
>