* [Qemu-devel] [PATCH] qcow2: Really use cache=unsafe for image creation
@ 2011-01-27 15:50 Kevin Wolf
2011-02-01 13:35 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Wolf @ 2011-01-27 15:50 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf
For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some
strange unsafe writethrough mode.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index dbe4fdd..a1773e4 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -975,7 +975,8 @@ static int qcow2_create2(const char *filename, int64_t total_size,
*/
BlockDriver* drv = bdrv_find_format("qcow2");
assert(drv != NULL);
- ret = bdrv_open(bs, filename, BDRV_O_RDWR | BDRV_O_NO_FLUSH, drv);
+ ret = bdrv_open(bs, filename,
+ BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, drv);
if (ret < 0) {
goto out;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Really use cache=unsafe for image creation
2011-01-27 15:50 [Qemu-devel] [PATCH] qcow2: Really use cache=unsafe for image creation Kevin Wolf
@ 2011-02-01 13:35 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-02-01 13:35 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Thu, Jan 27, 2011 at 3:50 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> For cache=unsafe we also need to set BDRV_O_CACHE_WB, otherwise we have some
> strange unsafe writethrough mode.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-01 13:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-27 15:50 [Qemu-devel] [PATCH] qcow2: Really use cache=unsafe for image creation Kevin Wolf
2011-02-01 13:35 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).