From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36026 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OUQ6A-0004Ma-Au
	for qemu-devel@nongnu.org; Thu, 01 Jul 2010 16:11:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OUQ5x-0006KO-HM
	for qemu-devel@nongnu.org; Thu, 01 Jul 2010 16:10:56 -0400
Received: from mail-px0-f173.google.com ([209.85.212.173]:55493)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <blauwirbel@gmail.com>) id 1OUQ5x-0006JC-8M
	for qemu-devel@nongnu.org; Thu, 01 Jul 2010 16:10:49 -0400
Received: by pxi6 with SMTP id 6so420243pxi.4
	for <qemu-devel@nongnu.org>; Thu, 01 Jul 2010 13:10:45 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1277982502-4196-2-git-send-email-weil@mail.berlios.de>
References: <1277982502-4196-1-git-send-email-weil@mail.berlios.de>
	<1277982502-4196-2-git-send-email-weil@mail.berlios.de>
From: Blue Swirl <blauwirbel@gmail.com>
Date: Thu, 1 Jul 2010 20:10:24 +0000
Message-ID: <AANLkTimKQ7ZS0JbTjwFy-MCcxoreFRpxh0qi1BCEAj6t@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] blockdev.h: Add GCC attribute (check
	format arguments)
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Thu, Jul 1, 2010 at 11:08 AM, Stefan Weil <weil@mail.berlios.de> wrote:
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> =C2=A0blockdev.h | =C2=A0 =C2=A03 ++-
> =C2=A01 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/blockdev.h b/blockdev.h
> index 23ea576..3c5c85d 100644
> --- a/blockdev.h
> +++ b/blockdev.h
> @@ -42,7 +42,8 @@ extern int drive_get_max_bus(BlockInterfaceType type);
> =C2=A0extern void drive_uninit(DriveInfo *dinfo);
> =C2=A0extern const char *drive_get_serial(BlockDriverState *bdrv);
>
> -extern QemuOpts *drive_add(const char *file, const char *fmt, ...);
> +extern QemuOpts *drive_add(const char *file, const char *fmt, ...)
> + =C2=A0 =C2=A0__attribute__ ((__format__ (__printf__, 2, 3)));
> =C2=A0extern DriveInfo *drive_init(QemuOpts *arg, int default_to_scsi,
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int *fatal_error);

I lost the cover letter, so this applies to all patches: Wouldn't it
make sense to make GCC_FMT_ATTR(n, m) from audio/audio_int.h available
universally and then use that?