From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34604 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OjyaK-00017m-0w for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:02:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OjyaI-0003EK-Aq for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:02:27 -0400 Received: from mail-qy0-f180.google.com ([209.85.216.180]:58521) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OjyaI-0003EA-8h for qemu-devel@nongnu.org; Fri, 13 Aug 2010 14:02:26 -0400 Received: by qyk11 with SMTP id 11so1282536qyk.4 for ; Fri, 13 Aug 2010 11:02:25 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Blue Swirl Date: Fri, 13 Aug 2010 18:02:05 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 0/5] CODING_STYLE amendments Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miguel Di Ciurcio Filho Cc: qemu-devel On Fri, Aug 13, 2010 at 3:22 PM, Miguel Di Ciurcio Filho wrote: > On Thu, Aug 12, 2010 at 3:56 PM, malc wrote: >> >> While intentions of this are good, i believe this goes too far, i doubt >> that the proposed additions are enforcable and have no doubts that they >> will be widely ignored and at the same time provide more grounds for >> whining. Furthermore the existing code doesn't follow them, going out on >> a limb, it's more likely that one would look around the code he/she >> modifies and base his/her modifications on the surrounding code than to >> follow the style that conflicts with it. > > The existing code that I have touched don't follow the current coding > style guidance, much less all the new recommendations being suggested. > > Although, I do believe that this situation needs to change. If we > agree in a coding style, I would volunteer to be a some kind of > observer to fix and alert people about coding styles mistakes. I fully agree on the need of change and support your excellent idea. There are other ways to solve the problem, but I believe we need more order than more chaos. Perhaps we the QEMU developers should appoint you the Guardian of the CODING_STYLE, and add a rule that no patch shall be committed without your CS-Acked-by line?